Google Git
Sign in
boringssl / boringssl / 89973806bc2ef652189e157f2736a7d32229c404
commit89973806bc2ef652189e157f2736a7d32229c404[log] [tgz]
authorDavid Benjamin <davidben@google.com>Tue May 13 13:24:48 2025 -0400
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 13 11:13:04 2025 -0700
tree37c07fccc29fd3bc715c5dda2a473ff8c676a363
parent2a514a51baebd5a232fc64f7b082f7a8b28cd29d [diff]
Tidy up some comments and #defines around salt lengths

https://boringssl-review.googlesource.com/c/boringssl/+/79267 will
bump the PKCS5_SALT_LEN constant to 16. To avoid some confusing results
from that:

1. Don't bother using a constant for EVP_BytesToKey (a generalized
   PBKDF1). It's not really doing anything there, since the public API
   just says 8 anyway.

2. Fix the structure citation from PKCS #5 (RFC 2898, now RFC 8018) to
   PKCS #12 (RFC 7292). This is actually the PKCS #12 version of the
   structure, which has no constraint on the salt length. See
   https://crbug.com/416889523#comment4

Bug: 416889523
Change-Id: I1aded3bf93c2ffc281b71013a6ea4135d39e28d9
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/79287
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: David Benjamin <davidben@google.com>
2 files changed
tree: 37c07fccc29fd3bc715c5dda2a473ff8c676a363
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. infra/
  11. pki/
  12. rust/
  13. ssl/
  14. third_party/
  15. tool/
  16. util/
  17. .bazelignore
  18. .bazelrc
  19. .bazelversion
  20. .clang-format
  21. .gitignore
  22. API-CONVENTIONS.md
  23. AUTHORS
  24. BREAKING-CHANGES.md
  25. BUILD.bazel
  26. build.json
  27. BUILDING.md
  28. CMakeLists.txt
  29. codereview.settings
  30. CONTRIBUTING.md
  31. FUZZING.md
  32. go.mod
  33. go.sum
  34. INCORPORATING.md
  35. LICENSE
  36. MODULE.bazel
  37. MODULE.bazel.lock
  38. PORTING.md
  39. PrivacyInfo.xcprivacy
  40. README.md
  41. SANDBOXING.md
  42. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: