tree 37c07fccc29fd3bc715c5dda2a473ff8c676a363
parent 2a514a51baebd5a232fc64f7b082f7a8b28cd29d
author David Benjamin <davidben@google.com> 1747157088 -0400
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> 1747159984 -0700

Tidy up some comments and #defines around salt lengths

https://boringssl-review.googlesource.com/c/boringssl/+/79267 will
bump the PKCS5_SALT_LEN constant to 16. To avoid some confusing results
from that:

1. Don't bother using a constant for EVP_BytesToKey (a generalized
   PBKDF1). It's not really doing anything there, since the public API
   just says 8 anyway.

2. Fix the structure citation from PKCS #5 (RFC 2898, now RFC 8018) to
   PKCS #12 (RFC 7292). This is actually the PKCS #12 version of the
   structure, which has no constraint on the salt length. See
   https://crbug.com/416889523#comment4

Bug: 416889523
Change-Id: I1aded3bf93c2ffc281b71013a6ea4135d39e28d9
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/79287
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: David Benjamin <davidben@google.com>