)]}'
{
  "commit": "89973806bc2ef652189e157f2736a7d32229c404",
  "tree": "37c07fccc29fd3bc715c5dda2a473ff8c676a363",
  "parents": [
    "2a514a51baebd5a232fc64f7b082f7a8b28cd29d"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue May 13 13:24:48 2025 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue May 13 11:13:04 2025 -0700"
  },
  "message": "Tidy up some comments and #defines around salt lengths\n\nhttps://boringssl-review.googlesource.com/c/boringssl/+/79267 will\nbump the PKCS5_SALT_LEN constant to 16. To avoid some confusing results\nfrom that:\n\n1. Don\u0027t bother using a constant for EVP_BytesToKey (a generalized\n   PBKDF1). It\u0027s not really doing anything there, since the public API\n   just says 8 anyway.\n\n2. Fix the structure citation from PKCS #5 (RFC 2898, now RFC 8018) to\n   PKCS #12 (RFC 7292). This is actually the PKCS #12 version of the\n   structure, which has no constraint on the salt length. See\n   https://crbug.com/416889523#comment4\n\nBug: 416889523\nChange-Id: I1aded3bf93c2ffc281b71013a6ea4135d39e28d9\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/79287\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: Adam Langley \u003cagl@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ac0f284a0129ded677356791d45d521eace79331",
      "old_mode": 33188,
      "old_path": "crypto/cipher/derive_key.cc",
      "new_id": "4dc493eddec238bf7aa9f5b5d8480025f505f6db",
      "new_mode": 33188,
      "new_path": "crypto/cipher/derive_key.cc"
    },
    {
      "type": "modify",
      "old_id": "4b5609d25ef008f86fb9b45462241781dc5ea994",
      "old_mode": 33188,
      "old_path": "crypto/pkcs8/pkcs8.cc",
      "new_id": "91a81fac02228e74c8958db77c0a8c73101ad4f2",
      "new_mode": 33188,
      "new_path": "crypto/pkcs8/pkcs8.cc"
    }
  ]
}
