Drop CBB allocation failure test.
To no great surprise, ASAN didn't like this test and I suspect that
Chromium, with its crashing allocator, won't like it either. Oh well.
Change-Id: I235dbb965dbba186f8f37d7df45f8eac9addc7eb
Reviewed-on: https://boringssl-review.googlesource.com/6496
Reviewed-by: Adam Langley <agl@google.com>
diff --git a/crypto/bytestring/bytestring_test.cc b/crypto/bytestring/bytestring_test.cc
index 4c2add6..f25c186 100644
--- a/crypto/bytestring/bytestring_test.cc
+++ b/crypto/bytestring/bytestring_test.cc
@@ -316,22 +316,6 @@
return true;
}
-static bool TestCBBAllocFailure() {
- CBB cbb;
- memset(&cbb, 0x42, sizeof(cbb));
-
- if (CBB_init(&cbb, (size_t)-1)) {
- fprintf(stderr, "Excessive allocation successful!\n");
- CBB_cleanup(&cbb);
- return false;
- }
-
- /* |CBB_init| should have cleared |cbb| before failing therefore this should
- * not crash. */
- CBB_cleanup(&cbb);
- return true;
-}
-
static bool TestCBBFinishChild() {
CBB cbb, child;
uint8_t *out_buf;
@@ -732,7 +716,6 @@
!TestGetASN1() ||
!TestCBBBasic() ||
!TestCBBFixed() ||
- !TestCBBAllocFailure() ||
!TestCBBFinishChild() ||
!TestCBBMisuse() ||
!TestCBBPrefixed() ||