| commit | eca12891ed873dc183624f28e4e5442e7bc2f4a2 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Nov 12 18:27:15 2024 -0500 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 12 23:50:37 2024 +0000 |
| tree | 53abcfdcbd468a1fba79d285c0555aa0e379c16e | |
| parent | 619da367f3979d36b0678dd3e0038f5453eff8ce [diff] |
Disable sdallocx detection by default The comment about it only detecting statically linked symbols is, as far as I can tell, not actually true? It gets picked up when you LD_PRELOAD libjemalloc. This means that if you have a binary where some random dependency pulls in libjemalloc, but you actually use a different malloc implementation without sdallocx, things break. We've also had an issue with https://github.com/grpc/grpc/issues/25450, though that one was a bit more obviously a problem with their build. Given this mess, and sdallocx not quite being standard, probably we should just leave this opt-in. Maybe decades from now, everyone will standardize on C23's free_sized. Or maybe we'll just be Rust by then. Update-Note: sdallocx detection can be restored by building with BORINGSSL_DETECT_SDALLOCX. Fixed: 378077860 Change-Id: I7c6bd718a154f31abec09623fddbdd0637380b9a Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/73030 Reviewed-by: Adam Langley <agl@google.com> Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: