)]}'
{
  "commit": "eca12891ed873dc183624f28e4e5442e7bc2f4a2",
  "tree": "53abcfdcbd468a1fba79d285c0555aa0e379c16e",
  "parents": [
    "619da367f3979d36b0678dd3e0038f5453eff8ce"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Nov 12 18:27:15 2024 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Nov 12 23:50:37 2024 +0000"
  },
  "message": "Disable sdallocx detection by default\n\nThe comment about it only detecting statically linked symbols is, as far\nas I can tell, not actually true? It gets picked up when you LD_PRELOAD\nlibjemalloc.\n\nThis means that if you have a binary where some random dependency pulls\nin libjemalloc, but you actually use a different malloc implementation\nwithout sdallocx, things break. We\u0027ve also had an issue with\nhttps://github.com/grpc/grpc/issues/25450, though that one was a bit\nmore obviously a problem with their build.\n\nGiven this mess, and sdallocx not quite being standard, probably we\nshould just leave this opt-in. Maybe decades from now, everyone will\nstandardize on C23\u0027s free_sized. Or maybe we\u0027ll just be Rust by then.\n\nUpdate-Note: sdallocx detection can be restored by building with\nBORINGSSL_DETECT_SDALLOCX.\n\nFixed: 378077860\nChange-Id: I7c6bd718a154f31abec09623fddbdd0637380b9a\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/73030\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9b466c1548ced65b23192f7025892fe550340cab",
      "old_mode": 33188,
      "old_path": "crypto/mem.c",
      "new_id": "2113a255278a70dee69cb3b98228b8c82a557591",
      "new_mode": 33188,
      "new_path": "crypto/mem.c"
    }
  ]
}
