commit d1d8eee76bea03ca9a2667dc06ccaa6a1e2565b8
author Pete Bentley <prb@google.com> Mon Jun 22 13:42:49 2020 +0100
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Mon Jun 22 14:06:04 2020 +0000
tree 8ac57c7a9fa5bcfa64d9926cb4aa149ce8c1840a
parent 33f8d33af0dcb083610e978baad5a8b6e1cfee82

Remove uneeded switch statement.

Warnings for switch statements with just a default case are
now fatal with the latest Windows toolchain used by Github
workflows. So indirectly this was breaking Conscrypt's
continuous integration and possibly other projects using
BoringSSL which run CI on Windows.

Example: https://github.com/google/conscrypt/runs/793502854?check_suite_focus=true

Change-Id: Ia09b86f3292299089c6536862a170677a8024984
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41844
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: David Benjamin <davidben@google.com>

decrepit/bio/base64_bio.c

diff --git a/decrepit/bio/base64_bio.c b/decrepit/bio/base64_bio.c
index 139d562..eb87186 100644
--- a/decrepit/bio/base64_bio.c
+++ b/decrepit/bio/base64_bio.c
@@ -513,17 +513,10 @@
 }
 
 static long b64_callback_ctrl(BIO *b, int cmd, bio_info_cb fp) {
-  long ret = 1;
-
   if (b->next_bio == NULL) {
     return 0;
   }
-  switch (cmd) {
-    default:
-      ret = BIO_callback_ctrl(b->next_bio, cmd, fp);
-      break;
-  }
-  return ret;
+  return BIO_callback_ctrl(b->next_bio, cmd, fp);
 }
 
 static const BIO_METHOD b64_method = {