Enable `check_prefixed_symbols` on the CI-only prefixed symbols builders. These are: - android_aarch64_prefixed_compile - ios64_prefixed_compile - linux_clang_prefixed_compile - mac_prefixed_compile Not touching the CQ ones yet as that can break CL submission. Bug: 543471701 Change-Id: I5c3137fdf58c71a60b2b152236ee1c886a6a6964 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/100547 Reviewed-by: Xiangfei Ding <xfding@google.com> Commit-Queue: Xiangfei Ding <xfding@google.com> Auto-Submit: Rudolf Polzer <rpolzer@google.com>
diff --git a/infra/config/generated/cr-buildbucket.cfg b/infra/config/generated/cr-buildbucket.cfg index c707e9d..f847d6a 100644 --- a/infra/config/generated/cr-buildbucket.cfg +++ b/infra/config/generated/cr-buildbucket.cfg
@@ -142,6 +142,7 @@ cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" properties_j: "android:true" + properties_j: "check_prefixed_symbols:true" properties_j: "cmake_args:{\"ANDROID_ABI\":\"arm64-v8a\",\"ANDROID_PLATFORM\":\"android-24\"}" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -524,6 +525,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "cmake_args:{\"CMAKE_OSX_ARCHITECTURES\":\"arm64\",\"CMAKE_OSX_SYSROOT\":\"iphoneos\"}" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -809,6 +811,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -1573,6 +1576,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" properties_j: "run_unit_tests:false" @@ -2630,6 +2634,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "android:true" + properties_j: "check_prefixed_symbols:true" properties_j: "cmake_args:{\"ANDROID_ABI\":\"arm64-v8a\",\"ANDROID_PLATFORM\":\"android-24\"}" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -2939,6 +2944,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "cmake_args:{\"CMAKE_OSX_ARCHITECTURES\":\"arm64\",\"CMAKE_OSX_SYSROOT\":\"iphoneos\"}" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -3098,6 +3104,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -3526,6 +3533,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" properties_j: "run_unit_tests:false"
diff --git a/infra/config/main.star b/infra/config/main.star index f46d3bd..d553b44 100755 --- a/infra/config/main.star +++ b/infra/config/main.star
@@ -777,6 +777,7 @@ "ANDROID_PLATFORM": "android-24", }, "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_LINUX_STATIC, }), ) @@ -938,6 +939,7 @@ "CMAKE_OSX_SYSROOT": "iphoneos", }, "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_MAC_STATIC, }), ) @@ -1235,6 +1237,7 @@ properties = compile_only({ "clang": True, "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_LINUX_STATIC, }), ) @@ -1358,6 +1361,7 @@ cq_enabled = False, properties = compile_only({ "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_MAC_STATIC, }), )