| commit | beaf594f8b3969219d531e6ba77a08387befc929 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Fri Jun 19 12:26:20 2020 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Fri Jun 19 21:46:02 2020 +0000 |
| tree | cd9c3ab9e4e293ef104c575b31bd968fc078715d | |
| parent | 991d31bbf11471d723f4a57a62100aff7f3cb9a5 [diff] |
Remove X509_get_signature_type. This macro dates to SSLeay. It is never used and for good reason: it doesn't do anything. EVP_PKEY_type returns NID_undef if the NID is not key type, but it is being passed in a signature algorithm type. This means that, except for invalid certificates, or the rare algorithms where the two OIDs match (Ed25519), it always returns NID_undef. Update-Note: If there are any calls to X509_get_signature_type, remove them. It more-or-less always returned NID_undef. Change-Id: I6e2e41f171143c28f2afce2890f029b776cc36b5 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41806 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: