tree cd9c3ab9e4e293ef104c575b31bd968fc078715d
parent 991d31bbf11471d723f4a57a62100aff7f3cb9a5
author David Benjamin <davidben@google.com> 1592583980 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1592603162 +0000

Remove X509_get_signature_type.

This macro dates to SSLeay. It is never used and for good reason: it
doesn't do anything. EVP_PKEY_type returns NID_undef if the NID is not
key type, but it is being passed in a signature algorithm type. This
means that, except for invalid certificates, or the rare algorithms
where the two OIDs match (Ed25519), it always returns NID_undef.

Update-Note: If there are any calls to X509_get_signature_type, remove
them. It more-or-less always returned NID_undef.

Change-Id: I6e2e41f171143c28f2afce2890f029b776cc36b5
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/41806
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>