| commit | bbd9f18fb6e6fdc69d21a16197298ff6375a17b0 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Fri Sep 09 11:57:14 2022 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 09 16:36:46 2022 +0000 |
| tree | 86b1b9681d1835d78b3140bf212e81139166a8a5 | |
| parent | d0a075012306873eac289d0485fe0446c7e89639 [diff] |
Document and tidy up X509_find_by_*. I put them under convenience functions because they're just wrappers over existing getters and comparison functions. Used very occasionally, but probably not important enough to put in the front of the header. I const-corrected all parameters except X509_NAME. X509_NAME is still a little tricky const-wise. (X509_NAME_cmp actually does take const names, so it would compile, but it's misleading because it would actually mutate the names.) While here, I tidied it up a little. X509_issuer_and_serial_cmp isn't really pulling its weight here and is forcing X509_find_by_issuer_and_serial to stack-allocate a fake, mostly uninitialized X509 object. The NULL check is also redundant because STACK_OF(T) treats NULL as the empty list anyway. With that, X509_issuer_and_serial_cmp is unused (I found no external callers), so remove it. It's not a particularly problematic function, so we can easily put it back, but if unused, one less to document. Update-Note: Removed X509_issuer_and_serial_cmp as it's unused. Bug: 426 Change-Id: I8785dea9b96265c1fea0c3c7b59e2979e223d819 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/54386 Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: Bob Beck <bbe@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: