)]}'
{
  "commit": "bbd9f18fb6e6fdc69d21a16197298ff6375a17b0",
  "tree": "86b1b9681d1835d78b3140bf212e81139166a8a5",
  "parents": [
    "d0a075012306873eac289d0485fe0446c7e89639"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Fri Sep 09 11:57:14 2022 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Sep 09 16:36:46 2022 +0000"
  },
  "message": "Document and tidy up X509_find_by_*.\n\nI put them under convenience functions because they\u0027re just wrappers\nover existing getters and comparison functions. Used very occasionally,\nbut probably not important enough to put in the front of the header.\n\nI const-corrected all parameters except X509_NAME. X509_NAME is still a\nlittle tricky const-wise. (X509_NAME_cmp actually does take const names,\nso it would compile, but it\u0027s misleading because it would actually\nmutate the names.)\n\nWhile here, I tidied it up a little. X509_issuer_and_serial_cmp isn\u0027t\nreally pulling its weight here and is forcing\nX509_find_by_issuer_and_serial to stack-allocate a fake, mostly\nuninitialized X509 object. The NULL check is also redundant because\nSTACK_OF(T) treats NULL as the empty list anyway.\n\nWith that, X509_issuer_and_serial_cmp is unused (I found no external\ncallers), so remove it. It\u0027s not a particularly problematic function, so\nwe can easily put it back, but if unused, one less to document.\n\nUpdate-Note: Removed X509_issuer_and_serial_cmp as it\u0027s unused.\nBug: 426\nChange-Id: I8785dea9b96265c1fea0c3c7b59e2979e223d819\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/54386\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a85c7c18a475e6e17e78cb07d47a34ce7fc2a657",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_cmp.c",
      "new_id": "b80d682bdf1d6d70c704bf911d5b6d7eeaa1b664",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_cmp.c"
    },
    {
      "type": "modify",
      "old_id": "a1931387103a92f044960873054d9a9bf83d5241",
      "old_mode": 33188,
      "old_path": "include/openssl/x509.h",
      "new_id": "e3369d95497b05608000e3f918833cb89ad15fee",
      "new_mode": 33188,
      "new_path": "include/openssl/x509.h"
    }
  ]
}