commit b7e5b08a20a45793c74f18e375acd34faaf896b2
author David Benjamin <davidben@google.com> Thu Sep 21 02:58:03 2017 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Fri Sep 22 13:52:37 2017 +0000
tree 7d484f131aab1495cd9aaa2a841980bae61286d9
parent b1b76aee3cb43ce11889403c5334283d951ebd37

Remove some redundant OPENSSL_cleanses.

Anything heap-allocated is automatically cleansed.

Change-Id: I88034251bcba7a3e74c0d1ec887dff5a4c16fa8b
Reviewed-on: https://boringssl-review.googlesource.com/20664
Commit-Queue: Steven Valdez <svaldez@google.com>
Reviewed-by: Steven Valdez <svaldez@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

ssl/handshake.cc

diff --git a/ssl/handshake.cc b/ssl/handshake.cc
index cef8a15..6746582 100644
--- a/ssl/handshake.cc
+++ b/ssl/handshake.cc
@@ -144,12 +144,6 @@
 }
 
 SSL_HANDSHAKE::~SSL_HANDSHAKE() {
-  OPENSSL_cleanse(secret, sizeof(secret));
-  OPENSSL_cleanse(early_traffic_secret, sizeof(early_traffic_secret));
-  OPENSSL_cleanse(client_handshake_secret, sizeof(client_handshake_secret));
-  OPENSSL_cleanse(server_handshake_secret, sizeof(server_handshake_secret));
-  OPENSSL_cleanse(client_traffic_secret_0, sizeof(client_traffic_secret_0));
-  OPENSSL_cleanse(server_traffic_secret_0, sizeof(server_traffic_secret_0));
   OPENSSL_free(cookie);
   OPENSSL_free(key_share_bytes);
   OPENSSL_free(ecdh_public_key);