| commit | ab5b457300b5c62140bf4bc6164ac3dc494f15af | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Jul 08 16:52:08 2025 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jul 09 09:05:33 2025 -0700 |
| tree | d0747f27ae46e6107aa286d008506a154cf28881 | |
| parent | c4c06c736016b69df6eee007005858b96c4cd8be [diff] |
Rename bn_mul_mont to bn_mul_mont_words https://boringssl-review.googlesource.com/c/boringssl/+/75647 tripped an issue where some build target was linking BoringSSL with a copy of OpenSSL. The particular combination of hidden and visible symbols meant that specifically changing bn_mul_mont impacted things. (Internal link for posterity: go/bn-mul-mont-symbol-collision resolves to the offending package.) We very much don't support that right now, but it's easiest to just rename this symbol right now. Long-term, I suspect we should properly prefix our symbols. (That will probably involve putting all non-asm internal symbols behind a C++ namespace, at which point we'll probably want to reevaluate our naming conventions anyway[*].) [*] I'd really like to call the new words-based mul and sqr bn_mul_words and bn_sqr_words, but OpenSSL has assembly functions with those names that do something else. go/bn-mul-mont-symbol-collision seems unaffected, but this is perhaps a sign that we should start namespacing our internals sooner rather than later. Change-Id: I8c6f362fd01bce51d89b58a08531910c6f1bd0a9 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/80308 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com> Auto-Submit: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: