)]}'
{
  "commit": "ab5b457300b5c62140bf4bc6164ac3dc494f15af",
  "tree": "d0747f27ae46e6107aa286d008506a154cf28881",
  "parents": [
    "c4c06c736016b69df6eee007005858b96c4cd8be"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Jul 08 16:52:08 2025 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Jul 09 09:05:33 2025 -0700"
  },
  "message": "Rename bn_mul_mont to bn_mul_mont_words\n\nhttps://boringssl-review.googlesource.com/c/boringssl/+/75647 tripped an\nissue where some build target was linking BoringSSL with a copy of\nOpenSSL. The particular combination of hidden and visible symbols meant\nthat specifically changing bn_mul_mont impacted things. (Internal link\nfor posterity: go/bn-mul-mont-symbol-collision resolves to the offending\npackage.)\n\nWe very much don\u0027t support that right now, but it\u0027s easiest to just\nrename this symbol right now. Long-term, I suspect we should properly\nprefix our symbols. (That will probably involve putting all non-asm\ninternal symbols behind a C++ namespace, at which point we\u0027ll probably\nwant to reevaluate our naming conventions anyway[*].)\n\n[*] I\u0027d really like to call the new words-based mul and sqr bn_mul_words\nand bn_sqr_words, but OpenSSL has assembly functions with those names\nthat do something else. go/bn-mul-mont-symbol-collision seems\nunaffected, but this is perhaps a sign that we should start namespacing\nour internals sooner rather than later.\n\nChange-Id: I8c6f362fd01bce51d89b58a08531910c6f1bd0a9\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/80308\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fe4d8cf3b5fceb5a311975a04fe7ff0f243b9ae7",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/asm/armv8-mont.pl",
      "new_id": "80e0eeae6dbc8299b1e0d8d66bf42b8afc21dae4",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/asm/armv8-mont.pl"
    },
    {
      "type": "modify",
      "old_id": "c3e30cbe43af91a2b9fe08a007d5c3ac31619254",
      "old_mode": 33261,
      "old_path": "crypto/fipsmodule/bn/asm/x86-mont.pl",
      "new_id": "59cfea67b947c80c080da127c555012a8a723720",
      "new_mode": 33261,
      "new_path": "crypto/fipsmodule/bn/asm/x86-mont.pl"
    },
    {
      "type": "modify",
      "old_id": "7c1ad402a3ef79efd8fc727582cb2f723bcc9bc3",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/bn_test.cc",
      "new_id": "6d241a0feff6a536c732de0024dccd8fbc4e7628",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/bn_test.cc"
    },
    {
      "type": "modify",
      "old_id": "205f4b43295e3da3a220cc013fdb05221a9425c3",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/exponentiation.cc.inc",
      "new_id": "a6c7d5530936266c0e5e75c56c6d3a0f99f81248",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/exponentiation.cc.inc"
    },
    {
      "type": "modify",
      "old_id": "ee881a98f075ecbb2a0f273247c8ed38d0ab5cfd",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/internal.h",
      "new_id": "3619ddd73b6da1a819fbb896aa681e886eb09d27",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/internal.h"
    },
    {
      "type": "modify",
      "old_id": "fe5c3a2216e18060c1ef036ee99e475717c7c863",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/bn/montgomery.cc.inc",
      "new_id": "6281b299ed6e2f90bf6df4e4526bae1ba5b8782a",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/bn/montgomery.cc.inc"
    },
    {
      "type": "modify",
      "old_id": "6aad968129861ddab466434cfbda2b033df93211",
      "old_mode": 33188,
      "old_path": "gen/bcm/armv8-mont-apple.S",
      "new_id": "fadf3e246324d73e802c47b6a57dcfeb1b758590",
      "new_mode": 33188,
      "new_path": "gen/bcm/armv8-mont-apple.S"
    },
    {
      "type": "modify",
      "old_id": "e49322b0c6e4ef5fb19d22eef78ee208fe9c09ad",
      "old_mode": 33188,
      "old_path": "gen/bcm/armv8-mont-linux.S",
      "new_id": "574647f82da70d86885b50d95215ac53721378d3",
      "new_mode": 33188,
      "new_path": "gen/bcm/armv8-mont-linux.S"
    },
    {
      "type": "modify",
      "old_id": "4091a5ada06ac98445c788ac7eb2886073b639fe",
      "old_mode": 33188,
      "old_path": "gen/bcm/armv8-mont-win.S",
      "new_id": "84f3473e5fa167620d9ee18a83091748b166d2a4",
      "new_mode": 33188,
      "new_path": "gen/bcm/armv8-mont-win.S"
    },
    {
      "type": "modify",
      "old_id": "6e549c71d43983a47ada5895eabc12aa996a449e",
      "old_mode": 33188,
      "old_path": "gen/bcm/x86-mont-apple.S",
      "new_id": "89e439bae28f7b7581120b7a06ec591583a40dc7",
      "new_mode": 33188,
      "new_path": "gen/bcm/x86-mont-apple.S"
    },
    {
      "type": "modify",
      "old_id": "21fbee22e6bb2ae3405e3d27798dd035a93f45f2",
      "old_mode": 33188,
      "old_path": "gen/bcm/x86-mont-linux.S",
      "new_id": "edf98a27fb522851a48729f2359c49aad4a72ed8",
      "new_mode": 33188,
      "new_path": "gen/bcm/x86-mont-linux.S"
    },
    {
      "type": "modify",
      "old_id": "d154078964cac28d69e8d8d2476efa43bed92fbf",
      "old_mode": 33188,
      "old_path": "gen/bcm/x86-mont-win.asm",
      "new_id": "f9d12bb0a8fede1895dbebf69f410d3598c80c3d",
      "new_mode": 33188,
      "new_path": "gen/bcm/x86-mont-win.asm"
    }
  ]
}