Use the same EVP_AEADs for TLS and DTLS

The funny AEADs enforce that the outgoing sequence numbers monotonically
increase, which is true for DTLS too. This is one less is_dtls boolean
to plumb.

When we first added this in
https://boringssl-review.googlesource.com/c/boringssl/+/16625, it didn't
work for DTLS because it checked the nonce started at zero, and our
DTLS 1.2 nonce construction (matching what ultimately ended up in the
DTLS 1.2 ChaCha20-Poly1305 ciphers) uses the combined epoch + seqnum.

But then https://boringssl-review.googlesource.com/c/boringssl/+/25384
made the AEAD check for any monotonically increasing sequence, so it's
perfectly DTLS-compatible.

Change-Id: I8e2e21527db85c682f2f4bd590d174f9015fcd35
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/71567
Reviewed-by: Bob Beck <bbe@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
5 files changed
tree: fc006c9ff97249e723305e95aaeac6a268bf74da
  1. .bcr/
  2. .github/
  3. cmake/
  4. crypto/
  5. decrepit/
  6. docs/
  7. fuzz/
  8. gen/
  9. include/
  10. pki/
  11. rust/
  12. ssl/
  13. third_party/
  14. tool/
  15. util/
  16. .bazelignore
  17. .bazelrc
  18. .clang-format
  19. .gitignore
  20. API-CONVENTIONS.md
  21. BREAKING-CHANGES.md
  22. BUILD.bazel
  23. build.json
  24. BUILDING.md
  25. CMakeLists.txt
  26. codereview.settings
  27. CONTRIBUTING.md
  28. FUZZING.md
  29. go.mod
  30. go.sum
  31. INCORPORATING.md
  32. LICENSE
  33. MODULE.bazel
  34. MODULE.bazel.lock
  35. PORTING.md
  36. PrivacyInfo.xcprivacy
  37. README.md
  38. SANDBOXING.md
  39. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: