commit 6abb37016e65419e1e58fb69296830f37e9c73f4
author David Benjamin <davidben@chromium.org> Tue May 05 09:13:47 2015 -0400
committer Adam Langley <agl@google.com> Wed May 06 22:56:31 2015 +0000
tree 74614598fa8fed8d6d05ab7a4fe833a64fd7b94d
parent d6e95eefba8ed542601fe4c9f5636e23b0e9b72c

Remove ciphers_raw.

With SSL_get0_raw_cipherlist gone, there's no need to hold onto it.

Change-Id: I258f8bfe21cc354211a777660df680df6c49df2a
Reviewed-on: https://boringssl-review.googlesource.com/4616
Reviewed-by: Adam Langley <agl@google.com>

ssl/internal.h

diff --git a/ssl/internal.h b/ssl/internal.h
index d1e667d..beeebb3 100644
--- a/ssl/internal.h
+++ b/ssl/internal.h
@@ -509,10 +509,6 @@
    * If NULL the parent SSL_CTX store is used instead. */
   X509_STORE *chain_store;
   X509_STORE *verify_store;
-
-  /* Raw values of the cipher list from a client */
-  uint8_t *ciphers_raw;
-  size_t ciphers_rawlen;
 } CERT;
 
 typedef struct sess_cert_st {

ssl/ssl_cert.c

diff --git a/ssl/ssl_cert.c b/ssl/ssl_cert.c
index 7b48ed8..6a4526e 100644
--- a/ssl/ssl_cert.c
+++ b/ssl/ssl_cert.c
@@ -324,7 +324,6 @@
   OPENSSL_free(c->client_certificate_types);
   X509_STORE_free(c->verify_store);
   X509_STORE_free(c->chain_store);
-  OPENSSL_free(c->ciphers_raw);
 
   OPENSSL_free(c);
 }

ssl/ssl_lib.c

diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
index 5fd70ba..a6d2587 100644
--- a/ssl/ssl_lib.c
+++ b/ssl/ssl_lib.c
@@ -1307,12 +1307,6 @@
     goto err;
   }
 
-  if (!CBS_stow(&cipher_suites, &s->cert->ciphers_raw,
-                &s->cert->ciphers_rawlen)) {
-    OPENSSL_PUT_ERROR(SSL, ssl_bytes_to_cipher_list, ERR_R_MALLOC_FAILURE);
-    goto err;
-  }
-
   while (CBS_len(&cipher_suites) > 0) {
     uint16_t cipher_suite;