Check for trailing data in X509Test.GeneralName. I accidentally lost these lines juggling patches around. Change-Id: I35551eeb0f1bb26dee74344048198a318c55209b Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44624 Commit-Queue: David Benjamin <davidben@google.com> Commit-Queue: Adam Langley <agl@google.com> Reviewed-by: Adam Langley <agl@google.com>
diff --git a/crypto/x509/x509_test.cc b/crypto/x509/x509_test.cc index 4020665..bde4339 100644 --- a/crypto/x509/x509_test.cc +++ b/crypto/x509/x509_test.cc
@@ -2975,6 +2975,7 @@ bssl::UniquePtr<GENERAL_NAME> a( d2i_GENERAL_NAME(nullptr, &ptr, kNames[i].size())); ASSERT_TRUE(a); + ASSERT_EQ(ptr, kNames[i].data() + kNames[i].size()); for (size_t j = 0; j < OPENSSL_ARRAY_SIZE(kNames); j++) { SCOPED_TRACE(Bytes(kNames[j])); @@ -2983,6 +2984,7 @@ bssl::UniquePtr<GENERAL_NAME> b( d2i_GENERAL_NAME(nullptr, &ptr, kNames[j].size())); ASSERT_TRUE(b); + ASSERT_EQ(ptr, kNames[j].data() + kNames[j].size()); if (i == j) { EXPECT_EQ(GENERAL_NAME_cmp(a.get(), b.get()), 0);