Fix some clang-tidy findings Change-Id: I4306d8c7451c6e168e1a7375e44dddb26a6a6964 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/102367 Reviewed-by: Adam Langley <agl@google.com> Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Lily Chen <chlily@google.com> Commit-Queue: Adam Langley <agl@google.com>
diff --git a/crypto/curve25519/curve25519_test.cc b/crypto/curve25519/curve25519_test.cc index b308162..9fc0036 100644 --- a/crypto/curve25519/curve25519_test.cc +++ b/crypto/curve25519/curve25519_test.cc
@@ -15,13 +15,10 @@ #include <limits.h> #include <stdint.h> -#include <gtest/gtest.h> +#include <algorithm> +#include <vector> -#include <openssl/bn.h> -#include <openssl/curve25519.h> -#include <openssl/digest.h> -#include <openssl/mem.h> -#include <openssl/rand.h> +#include <gtest/gtest.h> #include "../test/test_util.h" #include "internal.h"
diff --git a/crypto/test/file_test.cc b/crypto/test/file_test.cc index a2fa4bb..abdc716 100644 --- a/crypto/test/file_test.cc +++ b/crypto/test/file_test.cc
@@ -22,6 +22,7 @@ #include <errno.h> #include <limits.h> #include <stdarg.h> +#include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <string.h>
diff --git a/pki/path_builder_unittest.cc b/pki/path_builder_unittest.cc index 21b2e05..518fc3b 100644 --- a/pki/path_builder_unittest.cc +++ b/pki/path_builder_unittest.cc
@@ -16,6 +16,7 @@ #include <algorithm> #include <memory> +#include <utility> #include <gmock/gmock.h> #include <gtest/gtest.h>
diff --git a/pki/trust_store.cc b/pki/trust_store.cc index 94435e3..ef2b683 100644 --- a/pki/trust_store.cc +++ b/pki/trust_store.cc
@@ -14,20 +14,24 @@ #include "trust_store.h" +#include <algorithm> #include <cassert> #include <cstdint> #include <cstring> #include <optional> #include <string> +#include <utility> #include <openssl/base.h> #include <openssl/bytestring.h> #include <openssl/mem.h> #include <openssl/pool.h> +#include <openssl/span.h> #include "merkle_tree.h" #include "parse_certificate.h" #include "parsed_certificate.h" +#include "signature_algorithm.h" #include "string_util.h" BSSL_NAMESPACE_BEGIN
diff --git a/pki/trust_store_collection_unittest.cc b/pki/trust_store_collection_unittest.cc index cb1cdec..0d0284e 100644 --- a/pki/trust_store_collection_unittest.cc +++ b/pki/trust_store_collection_unittest.cc
@@ -23,6 +23,7 @@ #include <openssl/pool.h> #include "test_helpers.h" +#include "trust_store.h" #include "trust_store_in_memory.h" BSSL_NAMESPACE_BEGIN
diff --git a/ssl/ssl_cipher.cc b/ssl/ssl_cipher.cc index c36c194..be2e725 100644 --- a/ssl/ssl_cipher.cc +++ b/ssl/ssl_cipher.cc
@@ -23,6 +23,7 @@ #include <optional> #include <openssl/aead.h> +#include <openssl/bytestring.h> #include <openssl/err.h> #include <openssl/md5.h> #include <openssl/mem.h>