commit 51e3283d62eab1f2aab69f02b26f6b03896b5ccd
author David Benjamin <davidben@chromium.org> Wed Aug 13 15:13:57 2014 -0400
committer Adam Langley <agl@google.com> Wed Aug 13 21:59:51 2014 +0000
tree 512335a6ca0d7113cdea0f197fa824456f278542
parent 9174312be684ac8419ce243bf56dae74ded0aafb

Port dtls1_get_hello_verify to CBS.

Gives bounds checks and asserts that there's nothing after the cookie.

Change-Id: I8f9753e0c72670e9960f73a5722cefd9c02696a9
Reviewed-on: https://boringssl-review.googlesource.com/1507
Reviewed-by: Adam Langley <agl@google.com>

ssl/d1_clnt.c

diff --git a/ssl/d1_clnt.c b/ssl/d1_clnt.c
index 4405b17..e4f458e 100644
--- a/ssl/d1_clnt.c
+++ b/ssl/d1_clnt.c
@@ -585,9 +585,10 @@
 
 static int dtls1_get_hello_verify(SSL *s)
 	{
-	int n, al, ok = 0;
-	unsigned char *data;
-	unsigned int cookie_len;
+	long n;
+	int al, ok = 0;
+	CBS hello_verify_request, cookie;
+	uint16_t server_version;
 
 	s->first_packet = 1;
 	n=s->method->ssl_get_message(s,
@@ -607,10 +608,19 @@
 		return(1);
 		}
 
-	data = s->init_msg;
+	CBS_init(&hello_verify_request, s->init_msg, n);
+
+	if (!CBS_get_u16(&hello_verify_request, &server_version) ||
+		!CBS_get_u8_length_prefixed(&hello_verify_request, &cookie) ||
+		CBS_len(&hello_verify_request) != 0)
+		{
+		al = SSL_AD_DECODE_ERROR;
+		OPENSSL_PUT_ERROR(SSL, ssl3_get_cert_status, SSL_R_DECODE_ERROR);
+		goto f_err;
+		}
+
 #if 0
-	if (s->method->version != DTLS_ANY_VERSION &&
-		((data[0] != (s->version>>8)) || (data[1] != (s->version&0xff))))
+	if (s->method->version != DTLS_ANY_VERSION && server_version != s->version)
 		{
 		OPENSSL_PUT_ERROR(SSL, dtls1_get_hello_verify, SSL_R_WRONG_SSL_VERSION);
 		s->version=(s->version&0xff00)|data[1];
@@ -618,17 +628,15 @@
 		goto f_err;
 		}
 #endif
-	data+=2;
 
-	cookie_len = *(data++);
-	if ( cookie_len > sizeof(s->d1->cookie))
+	if (CBS_len(&cookie) > sizeof(s->d1->cookie))
 		{
 		al=SSL_AD_ILLEGAL_PARAMETER;
 		goto f_err;
 		}
 
-	memcpy(s->d1->cookie, data, cookie_len);
-	s->d1->cookie_len = cookie_len;
+	memcpy(s->d1->cookie, CBS_data(&cookie), CBS_len(&cookie));
+	s->d1->cookie_len = CBS_len(&cookie);
 
 	s->d1->send_cookie = 1;
 	return 1;