commit 4848294f43c34268181510a50a747e7b31bc8183
author David Benjamin <davidben@google.com> Fri May 21 19:06:00 2021 -0400
committer Adam Langley <agl@google.com> Thu Jun 03 17:49:51 2021 +0000
tree db01bda57306ef0d9b4cff3d92740cae4b9f3fba
parent 7a3e801217d2e052062fff2293156b7ba9e5e796

Remove impossible ssl->s3 null check.

ssl->s3 is never null. And if it were, we'd have crashed long before.

Change-Id: Idb441c3a91d8c77327a0f9a6d193a64367f347ee
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/47904
Reviewed-by: Adam Langley <agl@google.com>

ssl/t1_lib.cc

diff --git a/ssl/t1_lib.cc b/ssl/t1_lib.cc
index 420b6ee..e034bda 100644
--- a/ssl/t1_lib.cc
+++ b/ssl/t1_lib.cc
@@ -1958,7 +1958,7 @@
   // Per RFC 8446 section 4.1.4, skip offering the session if the selected
   // cipher in HelloRetryRequest does not match. This avoids performing the
   // transcript hash transformation for multiple hashes.
-  if (ssl->s3 && ssl->s3->used_hello_retry_request &&
+  if (ssl->s3->used_hello_retry_request &&
       ssl->session->cipher->algorithm_prf != hs->new_cipher->algorithm_prf) {
     return true;
   }