commit 43f375699f01873f0804836380a9db4ea31647ae
author David Benjamin <davidben@google.com> Tue Nov 10 22:30:44 2020 -0500
committer Adam Langley <agl@google.com> Tue Nov 17 21:47:57 2020 +0000
tree 42671a397e2fd885c2dde554dad276de6fe5300a
parent 2361677677f91f4f8aa029f6e479121e420638cd

Remove some unnecessary pointer casts.

Change-Id: I855e5c3811832eaddac4307fc40ca5bdeca15a98
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/44050
Reviewed-by: Adam Langley <agl@google.com>

crypto/asn1/a_type.c

diff --git a/crypto/asn1/a_type.c b/crypto/asn1/a_type.c
index cf5da20..f320e49 100644
--- a/crypto/asn1/a_type.c
+++ b/crypto/asn1/a_type.c
@@ -145,8 +145,7 @@
     case V_ASN1_UTF8STRING:
     case V_ASN1_OTHER:
     default:
-        result = ASN1_STRING_cmp((ASN1_STRING *)a->value.ptr,
-                                 (ASN1_STRING *)b->value.ptr);
+        result = ASN1_STRING_cmp(a->value.asn1_string, b->value.asn1_string);
         break;
     }
 

crypto/x509/x_crl.c

diff --git a/crypto/x509/x_crl.c b/crypto/x509/x_crl.c
index b1c485a..3b9f137 100644
--- a/crypto/x509/x_crl.c
+++ b/crypto/x509/x_crl.c
@@ -393,8 +393,7 @@
 
 static int X509_REVOKED_cmp(const X509_REVOKED **a, const X509_REVOKED **b)
 {
-    return (ASN1_STRING_cmp((ASN1_STRING *)(*a)->serialNumber,
-                            (ASN1_STRING *)(*b)->serialNumber));
+    return ASN1_STRING_cmp((*a)->serialNumber, (*b)->serialNumber);
 }
 
 int X509_CRL_add0_revoked(X509_CRL *crl, X509_REVOKED *rev)