Const-correct the kPrintMethods table

Change-Id: I002e9e37b77c2e63d6d6df3833b936f21eaec4d7
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/81657
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>

crypto/evp/print.cc

diff --git a/crypto/evp/print.cc b/crypto/evp/print.cc
index 01357e5..9464e36 100644
--- a/crypto/evp/print.cc
+++ b/crypto/evp/print.cc
@@ -226,7 +226,7 @@
   int (*param_print)(BIO *out, const EVP_PKEY *pkey, int indent);
 } EVP_PKEY_PRINT_METHOD;
 
-static EVP_PKEY_PRINT_METHOD kPrintMethods[] = {
+static const EVP_PKEY_PRINT_METHOD kPrintMethods[] = {
     {
         EVP_PKEY_RSA,
         rsa_pub_print,
@@ -241,15 +241,13 @@
     },
 };
 
-static size_t kPrintMethodsLen = OPENSSL_ARRAY_SIZE(kPrintMethods);
-
-static EVP_PKEY_PRINT_METHOD *find_method(int type) {
-  for (size_t i = 0; i < kPrintMethodsLen; i++) {
-    if (kPrintMethods[i].type == type) {
-      return &kPrintMethods[i];
+static const EVP_PKEY_PRINT_METHOD *find_method(int type) {
+  for (const auto &p : kPrintMethods) {
+    if (p.type == type) {
+      return &p;
     }
   }
-  return NULL;
+  return nullptr;
 }
 
 static int print_unsupported(BIO *out, const EVP_PKEY *pkey, int indent,
@@ -261,7 +259,7 @@
 
 int EVP_PKEY_print_public(BIO *out, const EVP_PKEY *pkey, int indent,
                           ASN1_PCTX *pctx) {
-  EVP_PKEY_PRINT_METHOD *method = find_method(EVP_PKEY_id(pkey));
+  const EVP_PKEY_PRINT_METHOD *method = find_method(EVP_PKEY_id(pkey));
   if (method != NULL && method->pub_print != NULL) {
     return method->pub_print(out, pkey, indent);
   }
@@ -270,7 +268,7 @@
 
 int EVP_PKEY_print_private(BIO *out, const EVP_PKEY *pkey, int indent,
                            ASN1_PCTX *pctx) {
-  EVP_PKEY_PRINT_METHOD *method = find_method(EVP_PKEY_id(pkey));
+  const EVP_PKEY_PRINT_METHOD *method = find_method(EVP_PKEY_id(pkey));
   if (method != NULL && method->priv_print != NULL) {
     return method->priv_print(out, pkey, indent);
   }
@@ -279,7 +277,7 @@
 
 int EVP_PKEY_print_params(BIO *out, const EVP_PKEY *pkey, int indent,
                           ASN1_PCTX *pctx) {
-  EVP_PKEY_PRINT_METHOD *method = find_method(EVP_PKEY_id(pkey));
+  const EVP_PKEY_PRINT_METHOD *method = find_method(EVP_PKEY_id(pkey));
   if (method != NULL && method->param_print != NULL) {
     return method->param_print(out, pkey, indent);
   }