commit 3ff161cc0876443bfa54c511b37d033312c81328
author David Benjamin <davidben@google.com> Sat Sep 26 12:58:13 2020 -0400
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Tue Sep 29 19:27:12 2020 +0000
tree 7f4a2558e20a8725a9c965d98b022d0c2485f13c
parent 437eabd0399a9293ba6c4501de293c51794cd70a

Print SSL_get_error in bssl_shim.

If a test fails due to an unexpected SSL_get_error result, notably 0-RTT
rejection, it's very difficult to debug.

Change-Id: I08585551f6d3d3c4ea414bf3ac7bc9ba0ed4063b
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/43085
Reviewed-by: Steven Valdez <svaldez@google.com>
Commit-Queue: David Benjamin <davidben@google.com>

ssl/test/bssl_shim.cc

diff --git a/ssl/test/bssl_shim.cc b/ssl/test/bssl_shim.cc
index 76df66d..55f9c38 100644
--- a/ssl/test/bssl_shim.cc
+++ b/ssl/test/bssl_shim.cc
@@ -804,6 +804,12 @@
   }
 
   if (!ret) {
+    // Print the |SSL_get_error| code. Otherwise, some failures are silent and
+    // hard to debug.
+    int ssl_err = SSL_get_error(ssl.get(), -1);
+    if (ssl_err != SSL_ERROR_NONE) {
+      fprintf(stderr, "SSL error: %s\n", SSL_error_description(ssl_err));
+    }
     return false;
   }