commit 3f1904bee1f1a119e48b4827579955cc11733e39
author Brian Smith <brian@briansmith.org> Thu Mar 10 17:16:02 2016 -1000
committer David Benjamin <davidben@google.com> Fri Mar 11 19:21:11 2016 +0000
tree acf069bb8031ffc0abdfa1eab0ab2481763aabd2
parent 6603b76f7616fe781ec6dcf3d66c82f29d776697

Set |bn->neg| to zero in |bn_set_words|.

If the values of any of the coordinates in the output point |r| were
negative during nistz256 multiplication, then the calls to
|bn_set_word| would result in the wrong coordinates being returned
(the negatives of the correct coordinates would be returned instead).
Fix that.

Change-Id: I6048e62f76dca18f625650d11ef5a051c9e672a4
Reviewed-on: https://boringssl-review.googlesource.com/7442
Reviewed-by: David Benjamin <davidben@google.com>

crypto/bn/bn.c

diff --git a/crypto/bn/bn.c b/crypto/bn/bn.c
index d960f12..0ecaf82 100644
--- a/crypto/bn/bn.c
+++ b/crypto/bn/bn.c
@@ -274,6 +274,7 @@
   /* |bn_wexpand| verified that |num| isn't too large. */
   bn->top = (int)num;
   bn_correct_top(bn);
+  bn->neg = 0;
   return 1;
 }