Fix some trailing whitespace in extension printer Change-Id: I620fd0d9d988727fe29be5902e2775b5198ecb52 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/88207 Auto-Submit: David Benjamin <davidben@google.com> Commit-Queue: Rudolf Polzer <rpolzer@google.com> Reviewed-by: Rudolf Polzer <rpolzer@google.com>
diff --git a/crypto/x509/v3_prn.cc b/crypto/x509/v3_prn.cc index 74f22e9..c2da548 100644 --- a/crypto/x509/v3_prn.cc +++ b/crypto/x509/v3_prn.cc
@@ -130,7 +130,7 @@ const ASN1_OBJECT *obj = X509_EXTENSION_get_object(ex); i2a_ASN1_OBJECT(bp, obj); j = X509_EXTENSION_get_critical(ex); - if (BIO_printf(bp, ": %s\n", j ? "critical" : "") <= 0) { + if (BIO_printf(bp, ":%s\n", j ? " critical" : "") <= 0) { return 0; } if (!X509V3_EXT_print(bp, ex, flag, indent + 4)) {
diff --git a/crypto/x509/x509_test.cc b/crypto/x509/x509_test.cc index 9d4444b..e2a4da5 100644 --- a/crypto/x509/x509_test.cc +++ b/crypto/x509/x509_test.cc
@@ -5996,7 +5996,6 @@ size_t data_len; ASSERT_TRUE(BIO_mem_contents(bio.get(), &data, &data_len)); auto print = BytesAsStringView(Span(data, data_len)); - // Note that the expected output contains trailing whitespace. EXPECT_EQ(print, R"(Certificate: Data: Version: 3 (0x2) @@ -6025,13 +6024,13 @@ X509v3 extensions: X509v3 Key Usage: critical Digital Signature, Key Encipherment - X509v3 Extended Key Usage: + X509v3 Extended Key Usage: TLS Web Server Authentication, TLS Web Client Authentication X509v3 Basic Constraints: critical CA:FALSE - X509v3 Subject Key Identifier: + X509v3 Subject Key Identifier: A3:79:A6:F6:EE:AF:B9:A5:5E:37:8C:11:80:34:E2:75 - X509v3 Authority Key Identifier: + X509v3 Authority Key Identifier: keyid:8C:1A:68:A8:B5:76:DB:5D:57:7B:1F:8D:14:B2:06:A3 Signature Algorithm: sha256WithRSAEncryption