commit 2958490127dbe0df3adb72bc8ffb04ebca1f4bbf
author Adam Langley <agl@chromium.org> Mon Sep 16 13:43:03 2024 -0700
committer Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 16 21:03:42 2024 +0000
tree d3b96fb903ade0810f6c2fc40322befec1aee73f
parent 67ceb11911eff695ab7f417e98c301773b2f830f

slhdsa: fix some ClangTidy warnings.

Change-Id: I9dca8533a59e214707862d6ece233a4332ced4d3
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/71328
Commit-Queue: Adam Langley <agl@google.com>
Auto-Submit: Adam Langley <agl@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>

crypto/slhdsa/slhdsa.c

diff --git a/crypto/slhdsa/slhdsa.c b/crypto/slhdsa/slhdsa.c
index ca04c3d..d8f0797 100644
--- a/crypto/slhdsa/slhdsa.c
+++ b/crypto/slhdsa/slhdsa.c
@@ -50,10 +50,11 @@
 
 void SLHDSA_SHA2_128S_generate_key(
     uint8_t out_public_key[SLHDSA_SHA2_128S_PUBLIC_KEY_BYTES],
-    uint8_t out_secret_key[SLHDSA_SHA2_128S_PRIVATE_KEY_BYTES]) {
+    uint8_t out_private_key[SLHDSA_SHA2_128S_PRIVATE_KEY_BYTES]) {
   uint8_t seed[3 * SLHDSA_SHA2_128S_N];
   RAND_bytes(seed, 3 * SLHDSA_SHA2_128S_N);
-  SLHDSA_SHA2_128S_generate_key_from_seed(out_public_key, out_secret_key, seed);
+  SLHDSA_SHA2_128S_generate_key_from_seed(out_public_key, out_private_key,
+                                          seed);
 }
 
 OPENSSL_EXPORT void SLHDSA_SHA2_128S_public_from_private(

crypto/slhdsa/slhdsa_test.cc

diff --git a/crypto/slhdsa/slhdsa_test.cc b/crypto/slhdsa/slhdsa_test.cc
index fe70fbd..56fe3b1 100644
--- a/crypto/slhdsa/slhdsa_test.cc
+++ b/crypto/slhdsa/slhdsa_test.cc
@@ -19,7 +19,6 @@
 #include <vector>
 
 #include <gtest/gtest.h>
-#include <openssl/bytestring.h>
 #include <openssl/slhdsa.h>
 
 #include "../test/file_test.h"