For AES-GCM-SIV, also require PCLMUL instruction set. It uses the VPCLMULQDQ instruction on XMM registers. This requires AVX and PCLMUL to be present. The existing test checks for AVX, AESNI only, but not for PCLMUL. Note that there exist no CPUs that have AVX and AESNI, but lack PCLMUL, as both Intel and AMD introduced AESNI together with PCLMUL in the same CPU generation. So this issue and fix is purely theoretical just in case a future CPU for some odd reason has a weird combination of features. Change-Id: I2cbcf8b5c165f4aba6e9b3127e6fc67d6a6a6964 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/95667 Reviewed-by: Xiangfei Ding <xfding@google.com> Commit-Queue: Rudolf Polzer <rpolzer@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.
There are other files in this directory which might be helpful: