commit 1c2779e819d5d3799ed73236649ba48204d41881
author Adam Langley <agl@google.com> Thu Aug 16 13:44:48 2018 -0700
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Thu Aug 16 20:59:45 2018 +0000
tree 189b674109b133160ea02dc3482d87b66e948f94
parent 929fd44f92c33cc1e96c77cf9d982fad1b3a0790

Don't let a NULL mean the initial SSL_CTX in SSL_set_SSL_CTX.

We broke this a while back and nothing noticed. (Note dereference just
above.) Therefore I guess we don't need to support it.

Change-Id: I501d43825e89acb5f7f13998541dc8ff59452a99
Reviewed-on: https://boringssl-review.googlesource.com/31144
Commit-Queue: Adam Langley <agl@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

ssl/ssl_lib.cc

diff --git a/ssl/ssl_lib.cc b/ssl/ssl_lib.cc
index a126561..120c276 100644
--- a/ssl/ssl_lib.cc
+++ b/ssl/ssl_lib.cc
@@ -2260,10 +2260,6 @@
     return NULL;
   }
 
-  if (ctx == NULL) {
-    ctx = ssl->session_ctx.get();
-  }
-
   UniquePtr<CERT> new_cert = ssl_cert_dup(ctx->cert.get());
   if (!new_cert) {
     return nullptr;