Google Git
Sign in
boringssl / boringssl / 0d9ea840bc8c482ca043fb9bbd6376088e37fbcc
commit0d9ea840bc8c482ca043fb9bbd6376088e37fbcc[log] [tgz]
authorBob Beck <bbe@google.com>Wed Apr 17 18:26:58 2024 -0600
committerBoringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 29 16:16:11 2024 +0000
tree65a97f581347c6ae0755e9d709180fcb87522cbb
parentd69e8b46184b6fd844a4a92b4a6f4347d08ee439 [diff]
Don't add extra 'informational' errors in the delegate

So when IsPublicKeyAcceptable returns false, this unambigiously
adds the UnacceptablePublicKey error to the certificate.

However the delegate currently adds an Additional error to the
certificate, to add some information about what was there.

This causes problems with tests in chrome that care about
seeing the unacceptable public key as such, without the
certificate being tagged as just having multiple errors and
therefore generically invalid.

Instead of adding an extra error for information, add
this as a warning, then there's no problem.

Change-Id: Id24e913df17f6c8bbc63c19b31df3f80e59f638b
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/67888
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: Bob Beck <bbe@google.com>
4 files changed
tree: 65a97f581347c6ae0755e9d709180fcb87522cbb
  1. .github/
  2. cmake/
  3. crypto/
  4. decrepit/
  5. fuzz/
  6. gen/
  7. include/
  8. pki/
  9. rust/
  10. ssl/
  11. third_party/
  12. tool/
  13. util/
  14. .bazelignore
  15. .bazelrc
  16. .clang-format
  17. .gitignore
  18. API-CONVENTIONS.md
  19. BREAKING-CHANGES.md
  20. BUILD.bazel
  21. build.json
  22. BUILDING.md
  23. CMakeLists.txt
  24. codereview.settings
  25. CONTRIBUTING.md
  26. FUZZING.md
  27. go.mod
  28. go.sum
  29. INCORPORATING.md
  30. LICENSE
  31. MODULE.bazel
  32. MODULE.bazel.lock
  33. PORTING.md
  34. PrivacyInfo.xcprivacy
  35. README.md
  36. SANDBOXING.md
  37. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

There are other files in this directory which might be helpful: