)]}'
{
  "commit": "0d9ea840bc8c482ca043fb9bbd6376088e37fbcc",
  "tree": "65a97f581347c6ae0755e9d709180fcb87522cbb",
  "parents": [
    "d69e8b46184b6fd844a4a92b4a6f4347d08ee439"
  ],
  "author": {
    "name": "Bob Beck",
    "email": "bbe@google.com",
    "time": "Wed Apr 17 18:26:58 2024 -0600"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Apr 29 16:16:11 2024 +0000"
  },
  "message": "Don\u0027t add extra \u0027informational\u0027 errors in the delegate\n\nSo when IsPublicKeyAcceptable returns false, this unambigiously\nadds the UnacceptablePublicKey error to the certificate.\n\nHowever the delegate currently adds an Additional error to the\ncertificate, to add some information about what was there.\n\nThis causes problems with tests in chrome that care about\nseeing the unacceptable public key as such, without the\ncertificate being tagged as just having multiple errors and\ntherefore generically invalid.\n\nInstead of adding an extra error for information, add\nthis as a warning, then there\u0027s no problem.\n\nChange-Id: Id24e913df17f6c8bbc63c19b31df3f80e59f638b\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/67888\nReviewed-by: David Benjamin \u003cdavidben@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "822019b91b91f125304b67da3e1b3c428f8ba43d",
      "old_mode": 33188,
      "old_path": "pki/simple_path_builder_delegate.cc",
      "new_id": "89000e3af790e79ffa2d14a6c4081d0b23c6a326",
      "new_mode": 33188,
      "new_path": "pki/simple_path_builder_delegate.cc"
    },
    {
      "type": "modify",
      "old_id": "8b3e8696ee023ff44dfb32277e02fc10f8c56c0f",
      "old_mode": 33188,
      "old_path": "pki/testdata/verify_certificate_chain_unittest/target-has-512bit-rsa-key/main.test",
      "new_id": "dfd7ff0c29c6d3271de2003293bbf992e036eac0",
      "new_mode": 33188,
      "new_path": "pki/testdata/verify_certificate_chain_unittest/target-has-512bit-rsa-key/main.test"
    },
    {
      "type": "modify",
      "old_id": "6af47f50684c3359670f0dd02a6bf0dff9c6b106",
      "old_mode": 33188,
      "old_path": "pki/testdata/verify_certificate_chain_unittest/target-signed-by-512bit-rsa/main.test",
      "new_id": "d94fd2b9f88f0c18f82be7de238a3cff681e2682",
      "new_mode": 33188,
      "new_path": "pki/testdata/verify_certificate_chain_unittest/target-signed-by-512bit-rsa/main.test"
    },
    {
      "type": "modify",
      "old_id": "9510fa946e718cf6c73b7cd1dd5c884a3902225d",
      "old_mode": 33188,
      "old_path": "pki/verify_certificate_chain.h",
      "new_id": "4603acefd13f9a1217f4dc6f123499d84de59c80",
      "new_mode": 33188,
      "new_path": "pki/verify_certificate_chain.h"
    }
  ]
}