runner: Don't override the version in the SendBothTickets tests Seems to work just fine without it. It's probably computing some garbage for the binder out of TLS 1.2's Finished construction, but ah well. (SendBothTickets is used when we send a TLS 1.2 ticket as a TLS 1.3 PSK identity.) Change-Id: I5e177d8fb3d73acd72745ca17968cf9bebefc811 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/89473 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Lily Chen <chlily@google.com>
diff --git a/ssl/test/runner/handshake_client.go b/ssl/test/runner/handshake_client.go index 3b7f499..8e8ad11 100644 --- a/ssl/test/runner/handshake_client.go +++ b/ssl/test/runner/handshake_client.go
@@ -878,15 +878,7 @@ // expect the server to reject ECH, so we put PSK last. Note this renders // ECH undecryptable. if len(hello.pskIdentities) > 0 { - sessionVers := session.vers - // We may have a pre-1.3 session if SendBothTickets is set. - if session.vers.protocolVersion() < VersionTLS13 { - sessionVers = version{VersionTLS13} - if c.isDTLS { - sessionVers = version{VersionDTLS13} - } - } - generatePSKBinders(sessionVers, hello, session, nil, nil, c.config) + generatePSKBinders(session.vers, hello, session, nil, nil, c.config) } if c.config.Bugs.SendClientHelloWithFixes != nil {