Revert "Fix VS build when assembler is enabled" This reverts commit 791f2822b25da0f69afc2aaa3d13c865af06fa82. The use of $<COMPILE_LANGUAGE:CXX> causes issues for the Visual Studio output of CMake[1] and the original CMake bug[2] was fixed in 3.13.0. [1] https://github.com/grpc/grpc/pull/20100#issuecomment-528817457 [2] https://gitlab.kitware.com/cmake/cmake/merge_requests/2179 Change-Id: I74ec9d258d2c068e0c58d97deda8aa3794d387e5 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/37364 Commit-Queue: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: David Benjamin <davidben@google.com>
diff --git a/CMakeLists.txt b/CMakeLists.txt index 761778a..d79d35f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt
@@ -242,11 +242,10 @@ add_definitions(-DNOMINMAX) # Allow use of fopen. add_definitions(-D_CRT_SECURE_NO_WARNINGS) - # VS 2017 and higher supports STL-only warning suppressions. Manually add to - # C++ only to work around a CMake quoting bug when using NASM with the Visual - # Studio generator. This will be fixed in CMake 3.13.0. See - # https://gitlab.kitware.com/cmake/cmake/merge_requests/2179 - add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-D_STL_EXTRA_DISABLED_WARNINGS=4774\ 4987>) + # VS 2017 and higher supports STL-only warning suppressions. + # A bug in CMake < 3.13.0 may cause the space in this value to + # cause issues when building with NASM. In that case, update CMake. + add_definitions("-D_STL_EXTRA_DISABLED_WARNINGS=4774 4987") endif() if((CMAKE_COMPILER_IS_GNUCXX AND CMAKE_C_COMPILER_VERSION VERSION_GREATER "4.7.99") OR