Remove some easy OPENSSL_EXPORTs

In principle, nothing in private headers should be OPENSSL_EXPORT. But
we've been a bit sloppy with unit tests (in hindsight, that maybe would
have been better done by static linking), and also sloppy in some FIPS
test binaries, so quite a lot of the BCM functions are OPENSSL_EXPORT.

These are the easy ones to undo. I've left the postquantum stuff alone
for now.

Change-Id: I13d954338a88c3534ffe27f1da7d0181847662bd
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/82987
Reviewed-by: Lily Chen <chlily@google.com>
Commit-Queue: Lily Chen <chlily@google.com>
Auto-Submit: David Benjamin <davidben@google.com>

crypto/fipsmodule/bcm_interface.h

diff --git a/crypto/fipsmodule/bcm_interface.h b/crypto/fipsmodule/bcm_interface.h
index ea0f291..b3624a3 100644
--- a/crypto/fipsmodule/bcm_interface.h
+++ b/crypto/fipsmodule/bcm_interface.h
@@ -83,7 +83,7 @@
 
 // BCM_rand_bytes is the same as the public |RAND_bytes| function, other
 // than returning a bcm_infallible status indicator.
-OPENSSL_EXPORT bcm_infallible BCM_rand_bytes(uint8_t *out, size_t out_len);
+bcm_infallible BCM_rand_bytes(uint8_t *out, size_t out_len);
 
 // BCM_rand_bytes_hwrng attempts to fill |out| with |len| bytes of entropy from
 // the CPU hardware random number generator if one is present.
@@ -797,26 +797,24 @@
 
 // BCM_aes_encrypt encrypts a single block from |in| to |out| with |key|. The
 // |in| and |out| pointers may overlap.
-OPENSSL_EXPORT bcm_infallible BCM_aes_encrypt(const uint8_t *in, uint8_t *out,
-                                              const AES_KEY *key);
+bcm_infallible BCM_aes_encrypt(const uint8_t *in, uint8_t *out,
+                               const AES_KEY *key);
 // BCM_aes_decrypt decrypts a single block from |in| to |out| with |key|. The
 // |in| and |out| pointers may overlap.
-OPENSSL_EXPORT bcm_infallible BCM_aes_decrypt(const uint8_t *in, uint8_t *out,
-                                              const AES_KEY *key);
+bcm_infallible BCM_aes_decrypt(const uint8_t *in, uint8_t *out,
+                               const AES_KEY *key);
 
 // BCM_aes_set_encrypt_key configures |aeskey| to encrypt with the |bits|-bit
 // key, |key|. |key| must point to |bits|/8 bytes. It will return failure if
 // |bits| is an invalid AES key size.
-OPENSSL_EXPORT bcm_status BCM_aes_set_encrypt_key(const uint8_t *key,
-                                                  unsigned bits,
-                                                  AES_KEY *aeskey);
+bcm_status BCM_aes_set_encrypt_key(const uint8_t *key, unsigned bits,
+                                   AES_KEY *aeskey);
 
 // BCM_aes_set_decrypt_key configures |aeskey| to decrypt with the |bits|-bit
 // key, |key|. |key| must point to |bits|/8 bytes. It will return failure if
 // |bits| is an invalid AES key size.
-OPENSSL_EXPORT bcm_status BCM_aes_set_decrypt_key(const uint8_t *key,
-                                                  unsigned bits,
-                                                  AES_KEY *aeskey);
+bcm_status BCM_aes_set_decrypt_key(const uint8_t *key, unsigned bits,
+                                   AES_KEY *aeskey);
 
 
 #if defined(__cplusplus)