Enable CI/CQ-based symbol prefixing verification on all Win static builds. Bug: 543471701 Change-Id: I11293c070b353875994c954a5ca487c16a6a6964 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/100550 Auto-Submit: Rudolf Polzer <rpolzer@google.com> Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> Commit-Queue: Xiangfei Ding <xfding@google.com> Reviewed-by: Xiangfei Ding <xfding@google.com>
diff --git a/infra/config/generated/cr-buildbucket.cfg b/infra/config/generated/cr-buildbucket.cfg index dabee0a..3ee841c 100644 --- a/infra/config/generated/cr-buildbucket.cfg +++ b/infra/config/generated/cr-buildbucket.cfg
@@ -1750,6 +1750,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "cmake_args:{\"CMAKE_ASM_FLAGS\":\"-m32 -msse2\",\"CMAKE_CXX_FLAGS\":\"-m32 -msse2\",\"CMAKE_C_FLAGS\":\"-m32 -msse2\",\"CMAKE_SYSTEM_NAME\":\"Windows\",\"CMAKE_SYSTEM_PROCESSOR\":\"x86\"}" properties_j: "msvc_target:\"x86\"" @@ -1785,6 +1786,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "msvc_target:\"x86\"" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -2068,6 +2070,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "msvc_target:\"x64\"" properties_j: "prefixed_symbols:true" @@ -2102,6 +2105,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "msvc_target:\"x64\"" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -2394,6 +2398,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "cmake_args:{\"CMAKE_SYSTEM_NAME\":\"Windows\",\"CMAKE_SYSTEM_PROCESSOR\":\"arm64\",\"OPENSSL_NO_ASM\":\"1\"}" properties_j: "gclient_vars:{\"checkout_nasm\":false}" properties_j: "msvc_target:\"arm64\"" @@ -2429,6 +2434,7 @@ cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" properties_j: "$gatekeeper:{\"group\":\"client.boringssl\"}" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "cmake_args:{\"CMAKE_ASM_FLAGS\":\"--target=arm64-windows\",\"CMAKE_CXX_FLAGS\":\"--target=arm64-windows\",\"CMAKE_C_FLAGS\":\"--target=arm64-windows\",\"CMAKE_SYSTEM_NAME\":\"Windows\",\"CMAKE_SYSTEM_PROCESSOR\":\"arm64\"}" properties_j: "gclient_vars:{\"checkout_nasm\":false}" @@ -3679,6 +3685,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "cmake_args:{\"CMAKE_ASM_FLAGS\":\"-m32 -msse2\",\"CMAKE_CXX_FLAGS\":\"-m32 -msse2\",\"CMAKE_C_FLAGS\":\"-m32 -msse2\",\"CMAKE_SYSTEM_NAME\":\"Windows\",\"CMAKE_SYSTEM_PROCESSOR\":\"x86\"}" properties_j: "msvc_target:\"x86\"" @@ -3718,6 +3725,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "msvc_target:\"x86\"" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -3933,6 +3941,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "msvc_target:\"x64\"" properties_j: "prefixed_symbols:true" @@ -3971,6 +3980,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "msvc_target:\"x64\"" properties_j: "prefixed_symbols:true" properties_j: "run_ssl_tests:false" @@ -4176,6 +4186,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "cmake_args:{\"CMAKE_SYSTEM_NAME\":\"Windows\",\"CMAKE_SYSTEM_PROCESSOR\":\"arm64\",\"OPENSSL_NO_ASM\":\"1\"}" properties_j: "gclient_vars:{\"checkout_nasm\":false}" properties_j: "msvc_target:\"arm64\"" @@ -4197,6 +4208,7 @@ name: "boringssl" cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build" cipd_version: "refs/heads/main" + properties_j: "check_prefixed_symbols:true" properties_j: "clang:true" properties_j: "cmake_args:{\"CMAKE_ASM_FLAGS\":\"--target=arm64-windows\",\"CMAKE_CXX_FLAGS\":\"--target=arm64-windows\",\"CMAKE_C_FLAGS\":\"--target=arm64-windows\",\"CMAKE_SYSTEM_NAME\":\"Windows\",\"CMAKE_SYSTEM_PROCESSOR\":\"arm64\"}" properties_j: "gclient_vars:{\"checkout_nasm\":false}"
diff --git a/infra/config/main.star b/infra/config/main.star index 09b714d..b75bcb5 100755 --- a/infra/config/main.star +++ b/infra/config/main.star
@@ -1455,6 +1455,7 @@ properties = compile_only({ "msvc_target": "x86", "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_WIN_STATIC, }), ) @@ -1535,6 +1536,7 @@ "CMAKE_CXX_FLAGS": "-m32 -msse2", }, "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_WIN_STATIC, }), ) @@ -1598,6 +1600,7 @@ properties = compile_only({ "msvc_target": "x64", "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_WIN_STATIC, }), ) @@ -1660,6 +1663,7 @@ "clang": True, "msvc_target": "x64", "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_WIN_STATIC, }), ) @@ -1704,6 +1708,7 @@ }, "msvc_target": "arm64", "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_WIN_STATIC, }), ) @@ -1744,6 +1749,7 @@ }, "msvc_target": "arm64", "prefixed_symbols": True, + "check_prefixed_symbols": True, "upload_to_cas": FINISHED_OUTPUT_FILES_WIN_STATIC, }), )