| commit | 4fa4804c8ab4521079af62dba5260a99c34b8a29 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Mar 12 09:48:29 2024 -0400 |
| committer | Boringssl LUCI CQ <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 12 15:17:20 2024 +0000 |
| tree | 02c9201fe5c38541326be03c1c3e7dead435f932 | |
| parent | dbad745811195c00b729efd0ee0a09b7d9fce1d2 [diff] |
Don't dereference hs->credential on TLS 1.2 PSK ciphers TLS 1.2 PSK ciphers don't use the credentials system and won't have a credential set. The OCSP and SCT extension callbacks didn't handle this case correctly. Since we were already checking for ssl_cipher_uses_certificate_auth in the OCSP one, which implies there's a credential, I opted to just fix the order of the conditions, as well as align the SCT one with it. I thought we had test coverage for this, but runner automatically configures a certificate even when it doesn't need one, so we never actually exercised this path. Refine the automatic behavior a bit. Change-Id: Idf7f06688fc51a2f5d23fd83c23f6da7035e27a7 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66927 Reviewed-by: Bob Beck <bbe@google.com> Commit-Queue: Bob Beck <bbe@google.com> Auto-Submit: David Benjamin <davidben@google.com> Reviewed-by: Pete Bentley <prb@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: