)]}'
{
  "commit": "4fa4804c8ab4521079af62dba5260a99c34b8a29",
  "tree": "02c9201fe5c38541326be03c1c3e7dead435f932",
  "parents": [
    "dbad745811195c00b729efd0ee0a09b7d9fce1d2"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Mar 12 09:48:29 2024 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Mar 12 15:17:20 2024 +0000"
  },
  "message": "Don\u0027t dereference hs-\u003ecredential on TLS 1.2 PSK ciphers\n\nTLS 1.2 PSK ciphers don\u0027t use the credentials system and won\u0027t have a\ncredential set. The OCSP and SCT extension callbacks didn\u0027t handle this\ncase correctly.\n\nSince we were already checking for ssl_cipher_uses_certificate_auth in\nthe OCSP one, which implies there\u0027s a credential, I opted to just fix\nthe order of the conditions, as well as align the SCT one with it.\n\nI thought we had test coverage for this, but runner automatically\nconfigures a certificate even when it doesn\u0027t need one, so we never\nactually exercised this path. Refine the automatic behavior a bit.\n\nChange-Id: Idf7f06688fc51a2f5d23fd83c23f6da7035e27a7\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66927\nReviewed-by: Bob Beck \u003cbbe@google.com\u003e\nCommit-Queue: Bob Beck \u003cbbe@google.com\u003e\nAuto-Submit: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Pete Bentley \u003cprb@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a5e4ec8886fe72e5ca689a531010b4fa6e2c1f14",
      "old_mode": 33188,
      "old_path": "ssl/extensions.cc",
      "new_id": "20a5d3034e77e06d9b5e12297fc346bd7baa4ce9",
      "new_mode": 33188,
      "new_path": "ssl/extensions.cc"
    },
    {
      "type": "modify",
      "old_id": "cd7fbca48c4ac833be82347b66e7d72112a34707",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/runner.go",
      "new_id": "8cc698bdc87683ef31e284d4bce55038a80efb90",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/runner.go"
    }
  ]
}