Update INSTANTIATE_TEST_SUITE_P calls missing first argument. This is going to be disallowed, apparently. Change-Id: I73868e1145f3e4e2438c2a31146ba0767b9f01fe Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/37684 Reviewed-by: David Benjamin <davidben@google.com> Commit-Queue: David Benjamin <davidben@google.com>
diff --git a/crypto/base64/base64_test.cc b/crypto/base64/base64_test.cc index 6905659..6484dc6 100644 --- a/crypto/base64/base64_test.cc +++ b/crypto/base64/base64_test.cc
@@ -105,7 +105,7 @@ class Base64Test : public testing::TestWithParam<Base64TestVector> {}; -INSTANTIATE_TEST_SUITE_P(, Base64Test, testing::ValuesIn(kTestVectors)); +INSTANTIATE_TEST_SUITE_P(All, Base64Test, testing::ValuesIn(kTestVectors)); // RemoveNewlines returns a copy of |in| with all '\n' characters removed. static std::string RemoveNewlines(const char *in) {
diff --git a/crypto/bio/bio_test.cc b/crypto/bio/bio_test.cc index 797a733..765e962 100644 --- a/crypto/bio/bio_test.cc +++ b/crypto/bio/bio_test.cc
@@ -220,7 +220,7 @@ } } -INSTANTIATE_TEST_SUITE_P(, BIOASN1Test, testing::ValuesIn(kASN1TestParams)); +INSTANTIATE_TEST_SUITE_P(All, BIOASN1Test, testing::ValuesIn(kASN1TestParams)); // Run through the tests twice, swapping |bio1| and |bio2|, for symmetry. class BIOPairTest : public testing::TestWithParam<bool> {}; @@ -322,4 +322,4 @@ EXPECT_EQ(Bytes("12345"), Bytes(buf, 5)); } -INSTANTIATE_TEST_SUITE_P(, BIOPairTest, testing::Values(false, true)); +INSTANTIATE_TEST_SUITE_P(All, BIOPairTest, testing::Values(false, true));
diff --git a/crypto/cipher_extra/aead_test.cc b/crypto/cipher_extra/aead_test.cc index c363750..caabb77 100644 --- a/crypto/cipher_extra/aead_test.cc +++ b/crypto/cipher_extra/aead_test.cc
@@ -103,7 +103,7 @@ const EVP_AEAD *aead() { return GetParam().func(); } }; -INSTANTIATE_TEST_SUITE_P(, PerAEADTest, testing::ValuesIn(kAEADs), +INSTANTIATE_TEST_SUITE_P(All, PerAEADTest, testing::ValuesIn(kAEADs), [](const testing::TestParamInfo<KnownAEAD> ¶ms) -> std::string { return params.param.name; });
diff --git a/crypto/fipsmodule/ec/ec_test.cc b/crypto/fipsmodule/ec/ec_test.cc index c0ad61f..9737d31 100644 --- a/crypto/fipsmodule/ec/ec_test.cc +++ b/crypto/fipsmodule/ec/ec_test.cc
@@ -800,7 +800,7 @@ return OBJ_nid2sn(params.param.nid); } -INSTANTIATE_TEST_SUITE_P(, ECCurveTest, testing::ValuesIn(AllCurves()), +INSTANTIATE_TEST_SUITE_P(All, ECCurveTest, testing::ValuesIn(AllCurves()), CurveToString); static bssl::UniquePtr<EC_GROUP> GetCurve(FileTest *t, const char *key) {
diff --git a/crypto/rsa_extra/rsa_test.cc b/crypto/rsa_extra/rsa_test.cc index ed1630d..0fe0351 100644 --- a/crypto/rsa_extra/rsa_test.cc +++ b/crypto/rsa_extra/rsa_test.cc
@@ -461,7 +461,7 @@ } } -INSTANTIATE_TEST_SUITE_P(, RSAEncryptTest, +INSTANTIATE_TEST_SUITE_P(All, RSAEncryptTest, testing::ValuesIn(kRSAEncryptParams)); TEST(RSATest, TestDecrypt) {