crypto/mldsa: Improve modulo reduction performance

Instead of a bitmask-based selection, we add or subtract the prime
masked by the condition. This gives better code generation:

Using the baseline 5d165bc0408b977a80247598834cddd2c99b788f on 3rd Gen Milan,
we have achieved these speedup on a single core.

Benchmark     | Base     | This     | Reduction
KeyGen-44     | 48.4  µs | 45.3  µs | -6.34%
KeyGen-65     | 82.6  µs | 75.5  µs | -8.57%
KeyGen-87     | 119.4 µs | 112.5 µs | -5.8%
Sign-44       | 153.1 µs | 142.7 µs | -6.8%
Sign-65       | 239.1 µs | 228.1 µs | -4.6%
Sign-87       | 286.6 µs | 262.1 µs | -8.5%
Verify-44     | 38.8  µs | 36.4  µs | -6.2%
Verify-65     | 61.2  µs | 57.5  µs | -6.1%
Verify-87     | 96.7  µs | 91.6  µs | -5.3%

As a side effect, it seems to stop Clang compiler from inserting
branches in constant-time code in non-production assert builds.
See crbug.com/583126010.

Bug: 583126010
Signed-off-by: Xiangfei Ding <xfding@google.com>
Change-Id: Ic37403bbbff2183d15509d2794a95a1a6a6a6964
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/105348
Presubmit-BoringSSL-Verified: boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com <boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Benjamin <davidben@google.com>
Reviewed-by: Adam Langley <agl@google.com>
1 file changed
tree: 14f49abe77dcbb47f47719b153b63c91ed4fb72e
  1. .agents/
  2. .bcr/
  3. .github/
  4. _agents/
  5. bench/
  6. cmake/
  7. crypto/
  8. decrepit/
  9. docs/
  10. fuzz/
  11. gen/
  12. include/
  13. infra/
  14. pki/
  15. rust/
  16. ssl/
  17. third_party/
  18. tool/
  19. util/
  20. .bazelignore
  21. .bazelrc
  22. .bazelversion
  23. .clang-format
  24. .clang-format-ignore
  25. .clangd
  26. .gitattributes
  27. .gitignore
  28. API-CONVENTIONS.md
  29. AUTHORS
  30. BREAKING-CHANGES.md
  31. BUILD.bazel
  32. build.json
  33. BUILDING.md
  34. CMakeLists.txt
  35. codereview.settings
  36. CONTRIBUTING.md
  37. FUZZING.md
  38. go.mod
  39. go.sum
  40. INCORPORATING.md
  41. LICENSE
  42. MODULE.bazel
  43. MODULE.bazel.lock
  44. PORTING.md
  45. PRESUBMIT.py
  46. PrivacyInfo.xcprivacy
  47. README.md
  48. SANDBOXING.md
  49. SECURITY.md
  50. STYLE.md
README.md

BoringSSL

BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.

Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.

Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.

BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.

Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.

Project links:

To file a security issue, use the Chromium process and mention in the report this is for BoringSSL. You can ignore the parts of the process that are specific to Chromium/Chrome.

There are other files in this directory which might be helpful: