)]}'
{
  "commit": "fcec391b0e90fadbf20f96de56b595925ceb7dd1",
  "tree": "cf7f41dd53ad80824833943a0ca0df77524f0358",
  "parents": [
    "ab7811ee8751ea699b22095caa70246f641ed3a2"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue Apr 20 14:58:30 2021 -0400"
  },
  "committer": {
    "name": "CQ bot account: commit-bot@chromium.org",
    "email": "commit-bot@chromium.org",
    "time": "Thu Apr 22 15:28:32 2021 +0000"
  },
  "message": "Remove some BoringSSL-only X509_CINF functions.\n\nThese functions are not in any released version of OpenSSL. The history\nis they were added to 1.0.2 beta for CT, but then removed in favor of\ni2d_re_X509_tbs. We forked in between the two events.\n\nI\u0027m not sure what the reasoning was upstream\u0027s end. I\u0027m thinking:\n\n- X509 currently only captures the serialized TBSCertificate. It might\n  be nice to capture the whole Certificate to avoid needing a\n  serialization in X509_cmp and make it easier to interop with other\n  stacks. (Unclear.) That would require not exporting the X509_CINF\n  standalone for serialization.\n\n- The modified bit means, without locking, i2d_X509 is not const or\n  thread-safe. We *might* be able to shift the re-encoding to\n  i2d_re_X509_tbs, which is already inherently non-const. That requires\n  not having X509_CINF_set_modified.\n\nI\u0027m not sure how feasible either of these are, but between that,\nupstream alignment, and X509_CINF otherwise being absent from public\naccessors, it seems worth removing.\n\nUpdate-Note: X509_get_cert_info, X509_CINF_set_modified, and\nX509_CINF_get_signature are removed. I believe all callers have been\nupdated. Callers should use i2d_re_X509_tbs, i2d_X509_tbs, and\nX509_get0_tbs_sigalg instead.\n\nChange-Id: Ic1906ba383faa7903973cb498402518985dd838c\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/46985\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d2d5ea75081cefc72fa378c3ca496e6b103bcc7a",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_set.c",
      "new_id": "77438683f1d5bdde23691477dae21bdea1a3dc79",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_set.c"
    },
    {
      "type": "modify",
      "old_id": "048e9ce1110b11b222c1d77bd731784da787d4d0",
      "old_mode": 33188,
      "old_path": "crypto/x509/x509_test.cc",
      "new_id": "e71cdeb18a0dab160b3ee575112abadf156e6256",
      "new_mode": 33188,
      "new_path": "crypto/x509/x509_test.cc"
    },
    {
      "type": "modify",
      "old_id": "3eb75017e4423e8460edd1f0cb220001712cf2b6",
      "old_mode": 33188,
      "old_path": "include/openssl/x509.h",
      "new_id": "949f120028dc3b87c7efb039337d571c33aff3f6",
      "new_mode": 33188,
      "new_path": "include/openssl/x509.h"
    }
  ]
}