)]}' { "commit": "fbec51725599f0f8b8f8c5a1f3e752932eb1a91d", "tree": "739cdeb8871b63f21e379aa1974adc7c0b74071c", "parents": [ "26b3fb0a7749028584ba5d31060e6fdd272c83e6" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Thu Nov 08 15:18:17 2018 -0600" }, "committer": { "name": "CQ bot account: commit-bot@chromium.org", "email": "commit-bot@chromium.org", "time": "Thu Nov 08 23:52:07 2018 +0000" }, "message": "Better test boundary cases of ec_cmp_x_coordinate.\n\nThis is done in preparation of generalizing the optimization to all our\nEC_METHODs.\n\nWycheproof happily does cover the case where x needed a reduction, but\nthey don\u0027t appear to check x being just above or below n, only x \u003d p - 1\n(adjusted downwards). Also we can tailor the test vectors a bit to the\nx \u003d\u003d r*z^2 (mod p) strategy to make sure we don\u0027t mess that up.\n\nAdditionally, the scenario is different for n \u003e p. There is also the\nnuisance of EC_FELEM vs EC_SCALAR having different widths. All our\nbuilt-in curves are well-behaved (same width, and consistently p \u003c n),\nbut secp160r1 is reachable from custom curves and violates both\nproperties. Generate some tests to cover it as well.\n\nChange-Id: Iefa5ebfe689a81870be21f04f5962ab161d38dab\nReviewed-on: https://boringssl-review.googlesource.com/c/32985\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\nCQ-Verified: CQ bot account: commit-bot@chromium.org \u003ccommit-bot@chromium.org\u003e\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "258c128c7fdeb9943bbd6f78a7bc17bfa0a28a32", "old_mode": 33188, "old_path": "crypto/fipsmodule/ecdsa/ecdsa_test.cc", "new_id": "4c95df9e16a8eb7319271893e043ce445cc9ef4b", "new_mode": 33188, "new_path": "crypto/fipsmodule/ecdsa/ecdsa_test.cc" }, { "type": "modify", "old_id": "aa2fbd3cd70c35190f9742be183d27b18aece2e7", "old_mode": 33188, "old_path": "crypto/fipsmodule/ecdsa/ecdsa_verify_tests.txt", "new_id": "9c4b889b88e5b5fac490c4c6f54cf3819996df09", "new_mode": 33188, "new_path": "crypto/fipsmodule/ecdsa/ecdsa_verify_tests.txt" } ] }