)]}' { "commit": "fa651134000bc6223a717a1ec8408746284d26b1", "tree": "8b53bd40c1eb2abf39ec416ce58c0009cd5973b8", "parents": [ "48669209b76dc2f28138a8c9342cb2616e5b820c" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Thu Feb 01 15:07:30 2018 -0500" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Thu Feb 01 21:43:42 2018 +0000" }, "message": "Push an error if custom private keys fail.\n\nThe private key callback may not push one of its own (it\u0027s possible to\nregister a custom error library and whatnot, but this is tedious). If\nthe callback does not push any, we report SSL_ERROR_SYSCALL. This is not\ncompletely wrong, as \"syscall\" really means \"I don\u0027t know, something you\ngave me, probably the BIO, failed so I assume you know what happened\",\nbut most callers just check errno. And indeed cert_cb pushes its own\nerror, so this probably should as well.\n\nUpdate-Note: Custom private key callbacks which push an error code on\n failure will report both that error followed by\n SSL_R_PRIVATE_KEY_OPERATION_FAILED. Callbacks which did not push any\n error will switch from SSL_ERROR_SYSCALL to SSL_ERROR_SSL with\n SSL_R_PRIVATE_KEY_OPERATION_FAILED.\n\nChange-Id: I7e90cd327fe0cbcff395470381a3591364a82c74\nReviewed-on: https://boringssl-review.googlesource.com/25544\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "4450958430897f91fb5485bf95182a82c62ce621", "old_mode": 33188, "old_path": "crypto/err/ssl.errordata", "new_id": "7b63bc8e707902453f89dffd19e181b489e05b17", "new_mode": 33188, "new_path": "crypto/err/ssl.errordata" }, { "type": "modify", "old_id": "a1b6fa79bd7eff94595420aca2bb2ed367845f64", "old_mode": 33188, "old_path": "include/openssl/ssl.h", "new_id": "249fce13b1473ecd79b996cb9fd1ac9a2bf4c324", "new_mode": 33188, "new_path": "include/openssl/ssl.h" }, { "type": "modify", "old_id": "134ad561ada758cc8987520a9f42d77e8864b2f8", "old_mode": 33188, "old_path": "ssl/ssl_privkey.cc", "new_id": "33cc720a526a583f83e485c9152947cea02ddfdf", "new_mode": 33188, "new_path": "ssl/ssl_privkey.cc" } ] }