| commit | f20772cc0a2eb5d66f59afe8b4fe3eeea5ca3687 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Tue Apr 07 15:18:23 2020 -0400 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Thu Apr 09 15:03:48 2020 +0000 |
| tree | 67383c77f531626f229754488d24c7a20ef92c1a | |
| parent | a49c617197b577f1f92153a295c11c762cd929f8 [diff] |
Make ec_GFp_simple_is_on_curve constant-time. This function (by way of EC_POINT_is_on_curve) is used by callers in two places: - To check the affine result of decoding a point. (This is no longer necessary because we'll always do it internally, but folks still do it.) - To check the Jacobian result of a multiplication as fault protection. (Tink does this. We should probably do it in the library.) That function's implementations of affine and Jacobian checks are mostly constant-time, but branching between the two isn't. Since the difference is small (2S + 1M vs 2S + 3M) compared to what one would be doing with an affine point (point multiplication), this probably isn't worth worrying about. Conservatively do the Jacobian check so folks like Tink aren't accidentally introducing side channels. Change-Id: I3140167868e027004906293df547add43ae40552 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/40590 Commit-Queue: David Benjamin <davidben@google.com> Reviewed-by: Adam Langley <agl@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
Project links:
There are other files in this directory which might be helpful: