)]}'
{
  "commit": "ef720d2e5d0ee2f4bbf9da82a6af126302084ce8",
  "tree": "4a1112e7adff6516e4e2d6e590390b10cdae14f6",
  "parents": [
    "e6fd36993cde9c69fbf496f5b15d4d5f2cbe3862"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Fri Feb 21 18:10:21 2025 -0500"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Feb 27 11:51:26 2025 -0800"
  },
  "message": "Iterate on SSL_CREDENTIAL_set_must_match_issuer a bit\n\nFirst, simplify the API a bit:\n- Just take a boolean param rather than having both set and clear\n  functions.\n- Unless we need it, no need to bother with a getter. We generally\n  assume that the caller knows what they configured.\n\nNext, expand on the docs and move it with other credential APIs, not\nSSL_PRIVATE_KEY_METHOD.\n\nFinally, fix a bug and test this in runner: the TLS 1.2 handshake forgot\nto check the issuer, which meant that it assumed all credentials were\nviable. Fix this and add tests to cover it all. In doing so, this pulls\nin the MustMatchIssuer runner plumbing out of\nhttps://boringssl-review.googlesource.com/c/boringssl/+/73087 to land a\nlittle sooner.\n\nAlso test that issuer matching works with delegated credentials. May as\nwell.\n\nChange-Id: I22aee148dd81fb9804d80b4243b68a5ecdead480\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/76708\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "eed27667bfa1e4264fa4229a7b9f52623596b21c",
      "old_mode": 33188,
      "old_path": "include/openssl/ssl.h",
      "new_id": "f06f2f2aa66b4418004e86b3fa56e1420fe63289",
      "new_mode": 33188,
      "new_path": "include/openssl/ssl.h"
    },
    {
      "type": "modify",
      "old_id": "7319df790627ee4251ee14379df29d5a933c7395",
      "old_mode": 33188,
      "old_path": "ssl/handshake_client.cc",
      "new_id": "4ce8d1802f78c456aa8d2829f3b263fe3d3e476e",
      "new_mode": 33188,
      "new_path": "ssl/handshake_client.cc"
    },
    {
      "type": "modify",
      "old_id": "9594210507986f8b4dfb1d2fa14d1c674cde7e2c",
      "old_mode": 33188,
      "old_path": "ssl/handshake_server.cc",
      "new_id": "ff275e7cedb7ded92f66e88b43173d96ef8062e9",
      "new_mode": 33188,
      "new_path": "ssl/handshake_server.cc"
    },
    {
      "type": "modify",
      "old_id": "fcd8ca5d156100cffd060d694d96cd17a7019cb2",
      "old_mode": 33188,
      "old_path": "ssl/ssl_credential.cc",
      "new_id": "94eaeffe6d4d02c43b56c0c68266ca72c53f83f3",
      "new_mode": 33188,
      "new_path": "ssl/ssl_credential.cc"
    },
    {
      "type": "modify",
      "old_id": "e7d83e44fa80614eab9000101c12881197fe797a",
      "old_mode": 33188,
      "old_path": "ssl/ssl_test.cc",
      "new_id": "b7e0a65181544f3d978cc9d037b686ee7d59ce07",
      "new_mode": 33188,
      "new_path": "ssl/ssl_test.cc"
    },
    {
      "type": "modify",
      "old_id": "daae594b489c4037bc312f3d25bcadd1622d6c37",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/common.go",
      "new_id": "1f2436160602d6efa8a1db442a9b5d354aa23471",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/common.go"
    },
    {
      "type": "modify",
      "old_id": "731902f243c85cdb54dc68d2191fdea1d1c31885",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/handshake_client.go",
      "new_id": "5fd5b7b5a4b2606bbba08add177fcb37ae5e2494",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/handshake_client.go"
    },
    {
      "type": "modify",
      "old_id": "651efb389988cffff28c2dd324c7a0a71497ba9c",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/handshake_messages.go",
      "new_id": "32a2732fccce3a9938db32a8613477cfe7f7e1b8",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/handshake_messages.go"
    },
    {
      "type": "modify",
      "old_id": "fe599568f70fc9a926763641f17165ef3dbaed0a",
      "old_mode": 33188,
      "old_path": "ssl/test/runner/runner.go",
      "new_id": "238e958317fe96ccd334245b927aaf947f3d77bc",
      "new_mode": 33188,
      "new_path": "ssl/test/runner/runner.go"
    },
    {
      "type": "modify",
      "old_id": "b3947fa6134a75ede57291d1f9ff2c1274314ad6",
      "old_mode": 33188,
      "old_path": "ssl/test/test_config.cc",
      "new_id": "6d3613a15f15877fc53cea19c7add804aad71769",
      "new_mode": 33188,
      "new_path": "ssl/test/test_config.cc"
    },
    {
      "type": "modify",
      "old_id": "6ddf620d317772250bc5ae63a38007944a74d508",
      "old_mode": 33188,
      "old_path": "ssl/test/test_config.h",
      "new_id": "d573d2190c506cdaafb31099f43d2197dfab7952",
      "new_mode": 33188,
      "new_path": "ssl/test/test_config.h"
    }
  ]
}