tree 21576544b9dfc9c48a37bf017c59afa079e2ebb8
parent 04dbb7f1d185af0837d46ac76bf899df6cdd2cc5
author Adam Langley <agl@chromium.org> 1409691176 -0700
committer Adam Langley <agl@google.com> 1409693450 +0000

Fix crash as server when resuming with SNI.

Thanks to Denis Denisov for noting that |host_name| could be used while
uninitialised in the resumption case.

While in the area, this change also renames |servername_done| to
something more reasonable and removes a documented value that was never
used. Additionally, the SNI ack was only sent when not resuming so
calculating whether it should be sent when processing ClientHello
extensions (which is after s->hit has been set) is superfluous.

Lastly, since SNI is only acked by servers, there's no need to worry
about the SNI callback returning NOACK in the client case.

Change-Id: Ie4ecfc347bd7afaf93b12526ff9311cc45da4df6
Reviewed-on: https://boringssl-review.googlesource.com/1700
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Adam Langley <agl@google.com>