)]}' { "commit": "eb2c2cdf17c2407981169b6b0dc749ace30ca952", "tree": "d144683029155b42d22b07cd6a28dcd02d6a07b2", "parents": [ "2f213f643f11cb45af5e405b596ff00ab007613b" ], "author": { "name": "David Benjamin", "email": "davidben@google.com", "time": "Sat Feb 02 19:06:06 2019 +0000" }, "committer": { "name": "Adam Langley", "email": "agl@google.com", "time": "Thu Feb 14 17:30:55 2019 +0000" }, "message": "Always define GHASH.\n\nThere is a C implementation of gcm_ghash_4bit to pair with\ngcm_gmult_4bit. It\u0027s even slightly faster per the numbers below (x86_64\nOPENSSL_NO_ASM build), but, more importantly, we trim down the\ncombinatorial explosion of GCM implementations and free up complexity\nbudget for potentially using bsaes better in the future.\n\nOld:\nDid 2557000 AES-128-GCM (16 bytes) seal operations in 1000057us (2556854.3 ops/sec): 40.9 MB/s\nDid 94000 AES-128-GCM (1350 bytes) seal operations in 1009613us (93105.0 ops/sec): 125.7 MB/s\nDid 17000 AES-128-GCM (8192 bytes) seal operations in 1024768us (16589.1 ops/sec): 135.9 MB/s\nDid 2511000 AES-256-GCM (16 bytes) seal operations in 1000196us (2510507.9 ops/sec): 40.2 MB/s\nDid 84000 AES-256-GCM (1350 bytes) seal operations in 1000412us (83965.4 ops/sec): 113.4 MB/s\nDid 15000 AES-256-GCM (8192 bytes) seal operations in 1046963us (14327.2 ops/sec): 117.4 MB/s\n\nNew:\nDid 2739000 AES-128-GCM (16 bytes) seal operations in 1000322us (2738118.3 ops/sec): 43.8 MB/s\nDid 100000 AES-128-GCM (1350 bytes) seal operations in 1008190us (99187.7 ops/sec): 133.9 MB/s\nDid 17000 AES-128-GCM (8192 bytes) seal operations in 1006360us (16892.6 ops/sec): 138.4 MB/s\nDid 2546000 AES-256-GCM (16 bytes) seal operations in 1000150us (2545618.2 ops/sec): 40.7 MB/s\nDid 86000 AES-256-GCM (1350 bytes) seal operations in 1000970us (85916.7 ops/sec): 116.0 MB/s\nDid 14850 AES-256-GCM (8192 bytes) seal operations in 1023459us (14509.6 ops/sec): 118.9 MB/s\n\nWhile I\u0027m here, tighten up some of the functions and align the ctr32 and\nnon-ctr32 paths.\n\nBug: 256\nChange-Id: Id4df699cefc8630dd5a350d44f927900340f5e60\nReviewed-on: https://boringssl-review.googlesource.com/c/34869\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "681f7a91271de5071531fd05cf113d92da01f379", "old_mode": 33188, "old_path": "crypto/fipsmodule/modes/gcm.c", "new_id": "97fde3e47f8cf747ef5755a6807659518b8c0f50", "new_mode": 33188, "new_path": "crypto/fipsmodule/modes/gcm.c" } ] }