| commit | e976e4349d693b4bbb97e1694f45be5a1b22c8c7 | [log] [tgz] |
|---|---|---|
| author | Adam Langley <alangley@gmail.com> | Mon Feb 15 14:01:10 2016 -0800 |
| committer | David Benjamin <davidben@google.com> | Thu Feb 18 15:45:48 2016 +0000 |
| tree | cd953431a4ce85ec73195d91ea1e8eef8508c929 | |
| parent | f48fcaf9010a04f2616174b6d61d321bdb21b791 [diff] |
Don't read uninitialised data for short session IDs. While it's always safe to read |SSL_MAX_SSL_SESSION_ID_LENGTH| bytes from an |SSL_SESSION|'s |session_id| array, the hash function would do so with without considering if all those bytes had been written to. This change checks |session_id_length| before possibly reading uninitialised memory. Since the result of the hash function was already attacker controlled, and since a lookup of a short session ID will always fail, it doesn't appear that this is anything more than a clean up. BUG=586800 Change-Id: I5f59f245b51477d6d4fa2cdc20d40bb6b4a3eae7 Reviewed-on: https://boringssl-review.googlesource.com/7150 Reviewed-by: David Benjamin <davidben@google.com>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: