)]}'
{
  "commit": "e7c3f473b97cfd575b9d347caabb4a28917bd168",
  "tree": "2164139af80adb5ef9c51d471c1feb664ae313a7",
  "parents": [
    "62f9751ade8373ae3339daee581c80a173206321"
  ],
  "author": {
    "name": "David Benjamin",
    "email": "davidben@google.com",
    "time": "Tue May 02 15:38:28 2023 -0400"
  },
  "committer": {
    "name": "Boringssl LUCI CQ",
    "email": "boringssl-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed May 03 18:09:26 2023 +0000"
  },
  "message": "Remove H from GCM128_KEY\n\nThis was originally removed in\nhttps://boringssl-review.googlesource.com/12477, but restored in\nhttps://boringssl-review.googlesource.com/c/boringssl/+/13122, which\nalso restored a comment the assembly code secretly relies on the struct\nlayout.\n\nOur comment references the MOVBE-based assembly, which could mean either\nthe stitched AES+GCM code, or the GHASH-only code. I don\u0027t see an\nobvious place where the GHASH-only code does this. The stitched ones\n(both x86_64 and aarch64, counter to the comment) did this, but the\npreceding CLs fix this. I think we can now remove this comment.\n\nIn OpenSSL, this comment dates to\nd8d958323bb116bf9f88137ba46948dcb1691a77 in upstream. That commit also\nremoved a field, so we can assume no assembly prior to that change\nrelied on that layout.\n\nThat commit immediately preceded\n1e86318091817459351a19e72f7d12959e9ec570, which was likely the\nmotivation. At the time, gcm_gmult_neon had some code with a comment\n\"point at H in GCM128_CTX\". At the time, Htable wasn\u0027t even filled in,\nand the function relied on H being 16 bytes before Htable.\ngcm_ghash_neon also relies on them being reachable from Xi.\n\nThis code changed in f8cee9d08181f9e966ef01d3b69ba78b6cb7c8a8 and, at a\nglance, the file doesn\u0027t seem to be making this assumption anymore. I\nthink, prior to that change, Htable wasn\u0027t filled in for the NEON code\nat all.\n\nWith all this now resolved, remove the comment and unused copy of H in\nGCM128_KEY.\n\nChange-Id: I4eb16cfff5dd41a59a0231a998d5502057336215\nReviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/59526\nReviewed-by: Adam Langley \u003cagl@google.com\u003e\nCommit-Queue: David Benjamin \u003cdavidben@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5932d606310f89cb6aa46d754e75c6e13c78d92a",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/modes/gcm.c",
      "new_id": "40ec0c8204ef9dd29dea0c3f32a306ee83bcf81f",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/modes/gcm.c"
    },
    {
      "type": "modify",
      "old_id": "3a28591ae7727171b5dd324bfaf6944cf3a8a819",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/modes/internal.h",
      "new_id": "7720baca64e84710148a8f2e776159fb9fb315a2",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/modes/internal.h"
    },
    {
      "type": "modify",
      "old_id": "833c75dc0c7ad4f25288c71f00b2e9893d73741c",
      "old_mode": 33188,
      "old_path": "crypto/fipsmodule/modes/polyval.c",
      "new_id": "a637188cd00f6e459ceca495d0737b50c8c4b7c8",
      "new_mode": 33188,
      "new_path": "crypto/fipsmodule/modes/polyval.c"
    },
    {
      "type": "modify",
      "old_id": "2219c211e9d62cb59df00808bea39ea454ba57a1",
      "old_mode": 33188,
      "old_path": "include/openssl/aead.h",
      "new_id": "7aa0b4492d2082669dfc8aa047b2dd1170fe78b9",
      "new_mode": 33188,
      "new_path": "include/openssl/aead.h"
    }
  ]
}