| commit | 672f6fc2486745d0cabc3aaeb4e0a3cd13b37b12 | [log] [tgz] |
|---|---|---|
| author | David Benjamin <davidben@google.com> | Wed Feb 21 16:22:34 2018 -0500 |
| committer | CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> | Thu Feb 22 22:28:15 2018 +0000 |
| tree | 232ff4f4cbaa8cbe360109535daa2a6c9a719662 | |
| parent | 36714fc8ee8764b2ae624d3c9dfdb1d798bb2924 [diff] |
Always use adr with __thumb2__. Thumb2 addresses are a bit a mess, depending on whether a label is interpreted as a function pointer value (for use with BX and BLX) or as a program counter value (for use with PC-relative addressing). Clang's integrated assembler mis-assembles this code. See https://crbug.com/124610#c54 for details. Instead, use the ADR pseudo-instruction which has clear semantics and should be supported by every assembler that handles the OpenSSL Thumb2 code. (In other files, the ADR vs SUB conditionals are based on __thumb2__ already. For some reason, this one is based on __APPLE__, I'm guessing to deal with an older version of clang assembler.) It's unclear to me which of clang or binutils is "correct" or if this is even a well-defined notion beyond "whatever binutils does". But I will note that https://github.com/openssl/openssl/pull/4669 suggests binutils has also changed behavior around this before. See also https://github.com/openssl/openssl/pull/5431 in OpenSSL. Bug: chromium:124610 Change-Id: I5e7a0c8c0f54a3f65cc324ad599a41883675f368 Reviewed-on: https://boringssl-review.googlesource.com/26164 Commit-Queue: Steven Valdez <svaldez@google.com> Reviewed-by: Steven Valdez <svaldez@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
BoringSSL is a fork of OpenSSL that is designed to meet Google's needs.
Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability.
Programs ship their own copies of BoringSSL when they use it and we update everything as needed when deciding to make API changes. This allows us to mostly avoid compromises in the name of compatibility. It works for us, but it may not work for you.
BoringSSL arose because Google used OpenSSL for many years in various ways and, over time, built up a large number of patches that were maintained while tracking upstream OpenSSL. As Google's product portfolio became more complex, more copies of OpenSSL sprung up and the effort involved in maintaining all these patches in multiple places was growing steadily.
Currently BoringSSL is the SSL library in Chrome/Chromium, Android (but it's not part of the NDK) and a number of other apps/programs.
There are other files in this directory which might be helpful: