tree 73321fe3c95d3323ca1962b7ab64681aefc29dff
parent 5ce7022394055e183c12368778d361461fe90a6e
author Pete Bentley <prb@google.com> 1568299392 +0100
committer CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> 1568303149 +0000

Only write self test flag files if an environment variable is set.

Prevents arbitrary processes linked against libcrypto, which run
before the self test binaries, from triggering SELinux audit logs.

Fails safe. I.e. default is not to write a flag file which in turn
will mean all processes loading libcrypto run a full set of KAT tests
until the variable is set.

Alternative considered:  Use a weak gloabl symbol containing the flag
(defaulting to "don't write") and override in the self test binaries.
However at the very least this would need to be in a separate object
file other than bcm.o to prevent local symbol resolution, so unsure
if that would be acceptable.

Change-Id: I32b20699bdd7ecaff06fc5f79b213d9a9d5f6253
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/37404
Reviewed-by: Adam Langley <agl@google.com>
Commit-Queue: Adam Langley <agl@google.com>